1688604 - [DE][obi.de] Highlight is not displayed for the expiry date and card type, form does not clear using "Clear Form"

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Screenshot of the issue

Affected Versions:

• All latest Firefox versions using force enable (Nightly 86, Beta RC 85.0, Release 84.0.2)

Tested on:

• MacOS 10.15
• Windows 10

Prerequisites:

• browser.search.region DE
• extensions.formautofill.supportedCountries DE
• download latest Firefox Nightly with region locale (switch extensions.formautofill.available to "on" for testing non-Nightly builds)

Steps to Reproduce:

1. Launch Firefox
2. Go to and reach the payment form for obi.de
3. Fill in the fields using the autofill feature from any field

Expected Results:
The card type should also be auto-filled.
The expiry date fields should be also highlighted and reset upon "Clear Form"

Actual Results:

1. The Card Type is not auto-filled
2. Expiry date is not highlighted and does not reset upon "Clear Form".

Notes:

• Severity: considering S3 given it works ok on Chrome
• Reproducible on Chrome?: No
• Regression-range: reproducible on all latest versions, this site was never tested before, can look for regression-range if need be

Comment 1

[Tim Giles [:tgiles]]

Since the expiry date is comprised of select elements, we won't give these elements highlights nor reset them to their original state when clearing form. We've been running into a few bugs where expiry date isn't highlighted so we may need to revisit that behavior and see if it needs changing. Out of curiosity, I went ahead and applied our current highlight styles to this select element...and the select dropdown arrow ends up disappearing. This is because we're using background-image for the autofill highlight styling. I checked with the old filter styling and the select dropdown arrow remains in this case.

Getting a consistent highlighting experience on expiry date seems like it's going to be a bit complicated, since Bug 1687682 ended up implementing the background-image styling to fix the card overlap bug.

I think why the card select is failing to autofill is because the German "Kartenmarke" is not in our heuristics for card type field identifiers. In this particular case, not having "Kartenmarke" in our heuristic is irrelevant because of the site's markup. I'd bet that we need to add "Kartenmarke" to our card type heuristic for some other bug.

It seems we're failing to identify the card type field and its associated label element. When we try to identify a particular field, we call _findMatchedFieldName. This ends up calling _getElementStrings() for a particular element. For some reason, when we call LabelUtils.findLabelElements for the card type input element, we get no labels back. Ah okay, we get no labels back because the visual label is semantically a <span> with a label class. In "generateLabelMap" we select all the label elements in the doc...and since this visual label is not semantically a label, we fail to pick it up and associate it with the card type form control.

Other than the word "label" being in the class name for this span element, there are no other hints that help create a relationship between the span element and the select element that is a child of the span's sibling

<div class="row brand">
    <span class="label">Kartenmarke</span>
     <div class="select">
          <select name="KKName">
                <option value="" selected=""></option>
                <option value="MasterCard">MasterCard</option>
                <option value="VISA">Visa</option>
          </select>
     </div>
</div>

This seems to be a combination of site specific bugs and previous feature request/defect. I haven't come across the context for why we don't highlight select elements and why we don't restore select elements to their initial value. I can see why we don't restore select elements, since they don't have an initialValue property unlike input elements. Select elements can be created without an initial value as well, so it might be difficult to know when to reset to a selected option within the select versus a blank value or the first value, etc.

If I stumble upon why we don't highlight expiry date select elements, I'll create a link between this bug and the found bug.

Comment 2

[Tim Giles [:tgiles]]

It seems Obi uses a different payment processor as I'm not reaching the Computop paygate screen that is attached to Comment #0. Because of this, credit card autofill fills as expected but we still have highlighting issues and clear form issues. This is because the current credit card fields are all separate iframes and so our form detection logic doesn't know how to handle this case. Because of this, this bug is blocked by Bug 1730016

Comment 3

[AnnaBelle]

Voir aussi : <a href="https://guide-scie-circulaire.fr">scie circulaire</a>
<a href="https://camera-thermique-pro.fr/">camera thermique</a>

Comment 4

[AnnaBelle]

(In reply to AnnaBelle from comment #3)
Voir aussi : https://guide-scie-circulaire.fr
https://camera-thermique-pro.fr

Comment 5

[AnnaBelle]

<a href="https://mozilla-hub.atlassian.net/browse/FXCM-44" target="_blank" rel="noreferrer">https://camera-thermique-pro.fr</a>

Comment 6

[AnnaBelle82]

https://lespetitesbohemes.com/