168881 - No more syntax highlighting for XML files, possible crashes in nsContentDLF::CreateInstance

Status: VERIFIED FIXED

(Core Graveyard :: View Source, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I made a mistake in my fix for bug  77337 that breaks highlighting of XML... The
problem is in nsContentDLF::CreateInstance.  The code that loops over HTML types
is fine, but we need to do

typeIndex = 0;

before looping over XML types (same for SVG and RDF).  In fact, what we do now
could lead to cool shit like crashing (and I would not be surprised if it has).

I don't have a tree, so can't produce a patch based on the above information,
but producing said patch should be a 2-minute job....

Comment 1

[timeless]

Attachment: patch

Comment 2

[rbs]

Comment on attachment 99554 [details] [diff] [review]
patch

r/sr=rbs

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 99554 [details] [diff] [review]
patch

sr=jst

Comment 4

[timeless]

checked in

Comment 5

[Boris Zbarsky [:bzbarsky]]

Timeless, thanks for doing that!  (I thought I cced caillon and asked him to
deal, but I guess I forgot...)

Comment 6

[Patty Mac]

Verified the patch.