1688886 - Optimize XDRImmutableScriptData

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Just like other stencil struct, we can encode/decode fields with codeBytes,
instead of encoding each field one by one.

Comment 1

[Tooru Fujisawa [:arai]]

Actually, ImmutableScriptData is already suitable for bulk-copy.
we just need to modify XDRImmutableScriptData.

Comment 2

[Tooru Fujisawa [:arai]]

WIP patch reduces 2% of the time taken by decoding and instantiating XDR data of yahoo-mail mail_app_es6_09*

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1688886 - Encode/decode ImmutableScriptData at once. r?tcampbell!

ImmutableScriptData is already packed, and doesn't contain pointers.
When encoding, it encode the entire data at once.
When decoding, it allocate ImmutableScriptData with given size, and then
read data, and then validate the size on debug build.

Depends on D103162

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/054668abe4fd
Encode/decode ImmutableScriptData at once. r=tcampbell

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/054668abe4fd