1688896 - Reorder case statements in "AboutLoginsChromeToContent" switch in aboutLogins.js

Status: RESOLVED FIXED

(Firefox :: about:logins, task, P5)

Description

[Tim Giles [:tgiles]]

To make this switch flow logically, we need to re-arrange some case statements in aboutLogins.js. These cases are ordered alphabetically.

Comment 1

[Jyoti Bisht]

Hi ! Can I work on this issue ?

Comment 2

[Tim Giles [:tgiles]]

Jyoti, thanks for volunteering! Feel free to go ahead and work on this!

To help Mozilla out with this bug, here's the steps:

2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Developer Guide,
     which has answers to most development questions.
3. Start working on this bug.
   • Please re-arrange the case statements in aboutLogins.js so that they are ordered alphabetically.
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #lockwise-desktop channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and test your change with
   mach test browser/components/aboutlogins/.
   Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 3

[Tim Giles [:tgiles]]

Hi Jyoti, do you still have time to work on this bug? Are you stuck somewhere in the setup/development process? Please let me know if I can help out or if you no longer can work on this bug. Thanks!

Comment 4

[Jyoti Bisht]

Hi TIM. So sorry for not being active but i have been travelling a lot going back to college and giving exams. But I do realize now in a day or two i could again start working on the bug day by day. Also, I've been meaning to ask can you let me know of the chat channel where in I can contact you and ask the doubts I will encounter? Please let me know and I will start with it asap as my last exam ends soon. Thank you for extending your help, I would be needing it !

Comment 5

[Jyoti Bisht]

Please let me know the chat channel to talk or the server on mozilla general. Thanks !

Comment 6

[Tim Giles [:tgiles]]

No worries Jyoti, just wanted to make sure you were willing and able to work on this bug! Thank you for the update, and please make sure you're focusing on your exams first! You can reach me on matrix in the Firefox Lockwise Desktop room. Again feel free to reach out and make sure you use Comment #2 as a reference when you start working...those links in that comment should help get you started

Comment 7

[Jyoti Bisht]

thank you so much. Will contact you soon and thanks for understanding! Consider me back and motivated as soon as my exams end in a week

Comment 8

[Tim Giles [:tgiles]]

Hi Jyoti, do you need help with this bug and/or do you still have time to work on this? Let me know if you need my help.

Comment 9

[Jyoti Bisht]

Hi Tim ! Sorry for the delay, getting started with the local setup today for firefox. Will update you with progress as I continue and will keep you in the loop ! Thanks for extending help, will surely need it !

Comment 10

[Cerkiewny]

Attachment: Bug 1688896 - alphabetically reorder switch statements in aboutLogins r?tgiles

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9991c6d57ea3
alphabetically reorder switch statements in aboutLogins r=tgiles

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9991c6d57ea3