1688932 - Firefox's PIP doesn't work in macOS full screen

Status: NEW

(Core :: Widget: Cocoa, defect, P2)

Description

[omarmichael2]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Enable PIP on a video and switch to another macOS full screen "space" (aka another virtual "desktop")

Actual results:

The Firefox PIP window does not follow across to the new virtual "desktop"/full-screen environment

Expected results:

The PIP window would remain in the position it was placed prior to switching between macOS spaces (similar to how Apple's Safari PIP operates or third-party Mac applications such as Helium or IINA).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello!

We tried to reproduce the issue by following the steps from comment 0 on macOS 10.15 and macOS 11.2.3 using Firefox 86.0a1 (20210106155127) and 88.0a1 (20210315091836). For us, the PiP window is moved across screens. Can you please attach a video with the steps for a better understanding? Thank you!

Comment 3

[omarmichael2]

Hello,

While making a screen recording I understand now that the issue I've been having with the Firefox PIP implementation (as opposed to Safari's PIP or the other two third-party applications mentioned) is that it doesn't float on top of a full screen window of any application including Firefox.

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to omarmichael2 from comment #3)

Hello,

While making a screen recording I understand now that the issue I've been having with the Firefox PIP implementation (as opposed to Safari's PIP or the other two third-party applications mentioned) is that it doesn't float on top of a full screen window of any application including Firefox.

Hello again!
Please let me know if we understand this correctly. Tested Firefox 88.0a1 (20210317212527) macOS 11.2.3 and 10.15.
So I found out these steps wich happens with native fullscreen as well:

1. Open Firefox and a Youtube video.
2. Enable PiP.
3. Enter Fullscreen on the Firefox window.
   AR: PiP window is not displayed over the Firefox window. Is this correct?

Also if I open PiP after Firefox is already in fullscreen mode it seems that PiP is displayed over the Firefox window. Thank you for your support!

Comment 5

[omarmichael2]

Hello!

Yes that is correct. I do see that if you open PiP after placing Firefox into full-screen mode it does display over the Firefox window. I tested this on my own system and that is the behavior I'm experiencing.

The issue I find in my workflow is that it seems to be that other applications (including Apple's first-party apps), whether full-screened before or after enabling PiP, won't show the Firefox's PiP floating above the application unlike the other PiP implementations mentioned in the original bug report.

Thank you for continuing to follow-up on this issue and I hope my comments were helpful.

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Thank you again for all the help.

Marking this as affected per comments above.

Comment 7

[Johan K. Jensen :johankj]

Attachment: Bug 1688932 - Make ToolbarWindow simulate NSPanel behavior to get floating windows r=#pip-reviewers!,#mac-reviewers!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Hi Johan,

It seems that the bug here is that when the main Firefox window is fullscreened, any PiP'd windows on the same display are overlapped (see comment 4). I've applied your patch, and I still see the same behaviour with and without the patch. Are we on the same page with what we're trying to fix here, or am I misunderstanding something?

Comment 9

[Johan K. Jensen :johankj]

As I understand the issue, the problem is that if you put a video in PIP and then visit any full screen application (Firefox, Slack, Terminal, etc.), then the PIP is not overlapping on top of Firefox.

As reported in comment #3:

the issue I've been having with the Firefox PIP implementation [...] is that it doesn't float on top of a full screen window of any application including Firefox.

To my understanding, this is the same issue as 1724402 and 1818745, and that’s what I’m attempting to fix.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Okay, thanks johankj. I've applied your patch, and I'm still not seeing how it's fixing things. Here's what I'm doing:

1. On a single display setup, I open Nightly with your patch applied
2. I go to a video website and use PiP to bring out the video.
3. I click on the green "+" button in the Nightly titlebar to "zoom" it and enter fullscreen

With your patch applied, the PiP'd video player still gets hidden. What am I missing here?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.

Comment 13

[Robert Ciang]

Hope this bug can be fixed soon since it has been recognized.