1688948 - Only set BrowsingContext's TouchEventsOverrideInternal from the parent

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Steven MacLeod [:smacleod]]

The proper fix for Bug 1677774 is to update all the callers and restructure things so that TouchEventsOverrideInternal is only set from the parent. While doing this BrowsingContext::CanSet for the field should be changed to reflect this (return XRE_IsParentProcess() && !aSource)

Comment 1

[Chris Peterson [:cpeterson]]

Fission MVP

Comment 2

[Neha Kochar [:neha]]

Edgar, can you please review this and confirm if MVP is an accurate milestone for this, or should this block release experiment (M8)?

Comment 3

[Edgar Chen [:edgar]]

I don't think it is a blocker of release experiment (M8).
touchEventOverride is only used by devtools, and devtools now only set it on parent process after bug 1704733.
But this bug should be easy to fix, taking it.

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 1688948 - Only allow BrowsingContext's TouchEventsOverrideInternal to be set from the parent process; r=nika

devtool only set it in parent process after bug 1704733.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ff299f97edd
Only allow BrowsingContext's TouchEventsOverrideInternal to be set from the parent process; r=nika

Comment 6

[Iulian Moraru]

Backed out for causing bc failures on browser_tab_touch_events.js.

Push with failures

Failure log

Backout link

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48819d6c56521fb37eb74a26225ad0076ff11a2f

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf63fe018162
Only allow BrowsingContext's TouchEventsOverrideInternal to be set from the parent process; r=nika

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cf63fe018162