Closed
Bug 1688995
Opened 3 years ago
Closed 3 years ago
Fall back to default $PATH if fzf doesn't exist in mozbuild
Categories
(Testing :: mozperftest, enhancement, P1)
Tracking
(firefox87 fixed)
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: sefeng, Assigned: sefeng)
Details
Attachments
(1 file)
The perftest command only expects the fzf binary to exist in .mozbuild, however, I don't think this is true. Looking at other testing commands, I've seen cases where we expect it to exist in the default $PATH like https://searchfox.org/mozilla-central/rev/0b2870194375d80b54608c39060884acb758c206/tools/tryselect/selectors/fuzzy.py#233.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → sefeng
Status: NEW → ASSIGNED
|
||
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P1
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92b6662598e9 Fall back to default PATH if fzf doesn't exist in mozbuild r=sparky
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•