1689044 - non-native theme disabled buttons are wider than non-disabled ones

Status: RESOLVED FIXED

(Core :: Widget, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689044 - Stop messing with button padding on :hover:active buttons by default. r=#layout-reviewers

This is not particularly efficient, and our non-native theme has
different paddings by default which causes test failures.

We could fix this with a bunch of other media queries, but it doesn't
seem worth it, other browsers don't do this, and we were already working
around it on mac anyways.

Comment 2

[Daniel Holbert [:dholbert]]

Quick testcase (which I confirmed reproduces the issue for me in current Nightly, when I have widget.disable-native-theme-for-content set to true:

data:text/html,<button>a</button><br><button disabled>a

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689044 - Remove redundant background-color: ButtonFace for buttons from forms.css. r=dholbert

This is the color that buttons have already, so this is just redundant.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a6bb25198c6
Stop messing with button padding on :hover:active buttons by default. r=dholbert

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3e7553bff14
Remove redundant background-color: ButtonFace for buttons from forms.css. r=dholbert

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8a6bb25198c6
https://hg.mozilla.org/mozilla-central/rev/e3e7553bff14