Closed Bug 1689064 Opened 3 years ago Closed 3 years ago

Optimized shaders produce completely broken rendering on Huawei MediaPad M2 (Mali-T628)

Categories

(Core :: Graphics: WebRender, defect, P3)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: jnicol, Assigned: jnicol)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Originally raised as part of bug 1687554, however on further investigation the issue is unrelated to, and long predates, the recent regression on the HTC 10.

Rendering is completely broken. Mozregression points to the commit which introduced optimized shaders. Setting gfx.webrender.use-optimized-shaders=false fixes rendering completely.

Attached image screenshot.png

By reducing the shader by hand, I managed to establish that removing the uniform sampler2D sGpuCache declaration from the fragment shader is what breaks the rendering. Manually adding the declaration back to the optimized fragment shaders fixes it.

I have so far been unable to work out why this is the case. I plan to disable optimized shaders on Mali-T6xx in the meantime.

Webrender's pre-optimized shaders result in completely broken
rendering on a Huawei MediaPad M2 (Mali-T628). As a precaution,
disable optimized shaders on all Mali-T6xx devices.

Pushed by jnicol@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5338c029ee7c
Disable optimized shaders on Mali-T6xx. r=aosmond

Ah, the tests crash because the new feature doesn't get initialized by them. A clever way of ensuring new features get tested properly! I'll initialize the feature and add the relevant assertions to the tests.

Flags: needinfo?(jnicol)
Pushed by jnicol@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e602ff8fea83
Disable optimized shaders on Mali-T6xx. r=aosmond

Sorry! It looks like I need to call ConfigureFromBlocklist() before ForceDisable() because webrender is disabled. Not sure why it only fails on windows and not linux where I tested..

This run looks greener so far: https://treeherder.mozilla.org/jobs?repo=try&revision=911750f05096b5f92384cd8855bcdcce7dc72352

Flags: needinfo?(jnicol)
Pushed by jnicol@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/312d863215bc
Disable optimized shaders on Mali-T6xx. r=aosmond
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: