1689078 - Clearly separate regular standalone function and event listener

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Currently "standalone function" in frontend means 2 things:

• Function (or generator/async) constructor call
• event handler with possible non-empty non-syntactic scope

treating both of them as "standalone function" sounds confusing,
we should add some new name for event handler case, to clarify what the target function is,
and separate the code for each case.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1689078 - Part 1: Assert the target of searchInEnclosingScope for non-delazification. r?mgaudet!

Compilation except delazification shouldn't access enclosing scope with
environment coordinate.

For eval, we shouldn't search in enclosing scope but just fallback to
either global or dynamic name access.

For other cases, the enclosing scope should be either empty global or null.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1689078 - Part 2: Add frontend::CompileStandaloneFunctionInNonSyntacticScope. r?mgaudet!

To make it clearer that a function with enclosing scope is special, and
different thing than standalone functions (new Function() etc), added dedicate
function/method for it.

Also refactored CreateNonSyntacticEnvironmentChain not to create scope, given
other consumers doesn't need it.

Depends on D103290

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1689078 - Part 3: Use fallbackFreeNameLocation_ for standalone function. r?mgaudet!

Depends on D103291

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/760701eca8bd
Part 1: Assert the target of searchInEnclosingScope for non-delazification. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b2990c289595
Part 2: Add frontend::CompileStandaloneFunctionInNonSyntacticScope. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/8dac478e6727
Part 3: Use fallbackFreeNameLocation_ for standalone function. r=mgaudet

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/760701eca8bd
https://hg.mozilla.org/mozilla-central/rev/b2990c289595
https://hg.mozilla.org/mozilla-central/rev/8dac478e6727