Closed Bug 1689081 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27348 - Revert "Element reflection implementation updates."

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27348 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27348
Details from upstream follow.

b'Amr Aboelkher <amraboelkher@google.com>' wrote:

Revert "Element reflection implementation updates."

This reverts commit a7db0486c804803565784f6d3fe26e18c64da3c1.

Reason for revert: One of the possible main causes for failure of tests in https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/94579/overview. Check the bug (crbug.com/1171230) for more details.

Original change's description:

Element reflection implementation updates.

Updating Element Reflection implementation to be inline with draft spec
changes.

Change-Id: Ia07910a62554a734d83d77dbb7e66dc4d7d74c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636746
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Meredith Lane \<meredithl@chromium.org>
Reviewed-by: Alice Boxhall \<aboxhall@chromium.org>
Commit-Queue: Chris Hall \<chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847518}

TBR=aboxhall@chromium.org,tkent@chromium.org,chrishall@chromium.org,meredithl@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ieecf3fb487f4481dc9b08e5461273e60f0feff9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2652527
Reviewed-by: Amr Aboelkher \<amraboelkher@google.com>
Commit-Queue: Amr Aboelkher \<amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#847578}

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 17 subtests

Status Summary

Firefox

OK : 1
FAIL: 17

Chrome

OK : 1
PASS: 17

Safari

OK : 1
FAIL: 17

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/dom/nodes/aria-element-reflection.tentative.html
aria-activedescendant element reflection: FAIL (Chrome: PASS, Safari: FAIL)
If the content attribute is set directly, the IDL attribute getter always returns the first element whose ID matches the content attribute.: FAIL (Chrome: PASS, Safari: FAIL)
Setting the IDL attribute to an element which is not the first element in DOM order with its ID causes the content attribute to be an empty string: FAIL (Chrome: PASS, Safari: FAIL)
Setting an element reference that crosses into a shadow tree is disallowed, but setting one that is in a shadow inclusive ancestor is allowed.: FAIL (Chrome: PASS, Safari: FAIL)
aria-errormessage: FAIL (Chrome: PASS, Safari: FAIL)
aria-details: FAIL (Chrome: PASS, Safari: FAIL)
Deleting a reflected element should return null for the IDL attribute and cause the content attribute to become stale.: FAIL (Chrome: PASS, Safari: FAIL)
Changing the ID of an element causes the content attribute to become out of sync.: FAIL (Chrome: PASS, Safari: FAIL)
Reparenting an element into a descendant shadow scope nullifies the element reference.: FAIL (Chrome: PASS, Safari: FAIL)
aria-labelledby.: FAIL (Chrome: PASS, Safari: FAIL)
aria-controls.: FAIL (Chrome: PASS, Safari: FAIL)
aria-describedby.: FAIL (Chrome: PASS, Safari: FAIL)
aria-flowto.: FAIL (Chrome: PASS, Safari: FAIL)
aria-owns.: FAIL (Chrome: PASS, Safari: FAIL)
shadow DOM behaviour for FrozenArray element reflection.: FAIL (Chrome: PASS, Safari: FAIL)
Moving explicitly set elements across shadow DOM boundaries.: FAIL (Chrome: PASS, Safari: FAIL)
Moving explicitly set elements around within the same scope, and removing from the DOM.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcb8871b7f2d [wpt PR 27348] - Revert "Element reflection implementation updates.", a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.