1689108 - Report TRR_IS_OFFLINE telemetry if the TRRService is NOT_CONFIRMED and the browser is offline

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

We don't know why the confirmation is not completed at all time, and excluding "browser is offline" as a cause will greatly help.

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1689108 - Report TRR_IS_OFFLINE telemetry if the TRRService is NOT_CONFIRMED and the browser is offline r=#necko

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1689108 - Report telemetry when TRRService is not confirmed because we have no connectivity r=#necko

Depends on D103234

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8ea21368fac
Report TRR_IS_OFFLINE telemetry if the TRRService is NOT_CONFIRMED and the browser is offline r=necko-reviewers,dragana

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e08ca2b3c36
Report telemetry when TRRService is not confirmed because we have no connectivity r=necko-reviewers,dragana

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a8ea21368fac
https://hg.mozilla.org/mozilla-central/rev/7e08ca2b3c36

Comment 6

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Comment on attachment 9199651 [details]
Bug 1689108 - Report TRR_IS_OFFLINE telemetry if the TRRService is NOT_CONFIRMED and the browser is offline r=#necko

Beta/Release Uplift Approval Request

• User impact if declined: No user impact. This small change alters the way we report telemetry for failure cases of DNS over HTTPS channels. Not having the patch in beta means our telemetry is less useful.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Involves only changes to the way we report a telemetry probe.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9199651 [details]
Bug 1689108 - Report TRR_IS_OFFLINE telemetry if the TRRService is NOT_CONFIRMED and the browser is offline r=#necko

Approved for 86 beta 4, thanks.

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3561b2c5cb83
https://hg.mozilla.org/releases/mozilla-beta/rev/606a8467e454