1689113 - Don't skip TRR if confirmation is still pending

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Currently TRR is completely blocked on confirmation. In mode 2 we have fallback anyway, so at least until we are sure that confirmation failed, we can do the lookup optimistically and let it fallback if something is wrong.

Additionally, we should avoid blocklisting individual hosts if confirmation state is not OK, because we don't do any logic to be sure that the failure is for an individual name.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1689113 - Don't skip TRR unless confirmation explicitly failed. r=#necko

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

This patch brings the total TRR_NOT_CONFIRMED failures at startup down from 10 to 1 on my local build.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d62bdce52f9bcc651fcf603ba396ec32a470ef3a

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

The semantics of Enabled() are slightly different than my first interpretation. Patch updated and new try push is here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0a365853f5ba313918670bb7fa087d93ff534cf
https://treeherder.mozilla.org/#/jobs?repo=try&revision=83b96c0d8acc065587524844071586bcd33ec43d

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce2be37814626ebd9d4dd686b2bf100edfb03ff0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d463a5795a3
Don't skip TRR unless confirmation explicitly failed. r=necko-reviewers,valentin

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7d463a5795a3