1689130 - Improve PrincipalVerifier crash annotations

Status: RESOLVED WONTFIX

(Core :: Storage: Quota Manager, task)

Description

[Simon Giesecke [:sg] [he/him]]

There are some things that should be improved about the PrincipalVerifier crash annotations:

• The current messages are quite opaque about which properties are inconsistent.
• In case there's a mismatch for the originNoSuffix, the baseDomain is not checked and therefore not reported.
• When the baseDomain is a URI (is it always a URI?), the protocol is "anonymized", which seems unnecessary.
• It's not clear in what context the PrincipalVerifier was called. There are currently two contexts, see https://searchfox.org/mozilla-central/search?q=symbol:_ZN7mozilla3dom5quota12_GLOBAL__N_117PrincipalVerifier17CreateAndDispatchEO8nsTArrayINS_3ipc13PrincipalInfoEE&redirect=false. A static identifier of that context could be passed to the PrincipalVerifier instance, and it could include it in its crash annotation.

Comment 1

[Jan Varga [:janv]]

The principal verifier has been removed in bug 1810412.