1689209 - libsrtp AES-GCM tests fail

Status: RESOLVED DUPLICATE of bug 1637488

(NSS :: Libraries, defect)

Description

[Martin Thomson [:mt:]]

https://github.com/cisco/libsrtp/issues/523 reports PK11_Encrypt failing in 3.60.1. The last known working version is 3.49.

Comment 1

[Kevin Jacobs [:kjacobs]]

This might be due to the PKCS #11 CK_GCM_PARAMS change noted in https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.52_release_notes#notable_changes_in_nss_3.52.

Comment 2

[pascal]

I can at least confirm that adding "#define NSS_PKCS11_2_0_COMPAT 1" to the top of the file fixes it if that is related.

Comment 3

[Kevin Jacobs [:kjacobs]]

(In reply to pascal from comment #2)

I can at least confirm that adding "#define NSS_PKCS11_2_0_COMPAT 1" to the top of the file fixes it if that is related.

Good news. You might find this helpful for some alternatives: https://bugzilla.mozilla.org/show_bug.cgi?id=1637488#c3

Comment 4

[pascal]

So based on the that link the simple option is to use NSS_PKCS11_2_0_COMPAT for now, as I do not want to push any nss version requirements on consumers of libsrtp just yet, is that how you read it ?

Comment 5

[Kevin Jacobs [:kjacobs]]

(In reply to pascal from comment #4)

So based on the that link the simple option is to use NSS_PKCS11_2_0_COMPAT for now, as I do not want to push any nss version requirements on consumers of libsrtp just yet, is that how you read it ?

That's correct, yes.

Comment 6

[Martin Thomson [:mt:]]

I think that we can shelve this. Though it might be better to change the parameter object, that's something libsrtp can manage now. I'm going to dupe this to the other bug, which is already resolved.