1689218 - Consolidate nsBaseHashtable::MaybeGet and GetAndRemove

Status: RESOLVED FIXED

(Core :: XPCOM, task, P3)

Description

[Jan Varga [:janv]]

This has been raised in https://phabricator.services.mozilla.com/D99428

"If we stick with GetAndRemove as the name of the other method, then MaybeGet should also be Get (and that should replace the existing Get which doesn't return a Maybe).

Alternatively, both methods should be named something with Maybe.

A third alternative might be to make the result type dependent on the UserDataType: If the UserDataType is default-constructible, both Get/GetAndRemove would return UserDataType, otherwise Maybe<UserDataType> (and we wouldn't need any methods named Maybe)."

Comment 1

[Simon Giesecke [:sg] [he/him]]

I will provide a patch to rename GetAndRemove to Extract, analogous to Maybe::extract.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1689218 - Rename nsBaseHashtable::GetAndRemove to Extract. r=#xpcom-reviewers

First, it should be called "Lookup" rather than "Get" because it returns
DataType (rather than UserDataType), but that would still be confusing,
since as opposed to other Lookup* methods, it does not return a DataType&
(and obviously, it can't). So "Extract" seems to be a better name, cf.
mozilla::Maybe::extract.

Depends on D105470

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbb46f16e00f
Rename nsBaseHashtable::GetAndRemove to Extract. r=necko-reviewers,dragana

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/dbb46f16e00f