Closed Bug 1689222 Opened 3 years ago Closed 3 years ago

MediaSource.prototype.onsourceclosed event handler attribute typo (trailing d)

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: foolip, Assigned: jbauman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_1_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36

Steps to reproduce:

Evaluate new MediaSource().onsourceclose and new MediaSource().onsourceclosed. Or try using the onsourceclose (sans d) event handler attribute to handle the "sourceclose" event.

Actual results:

The supported event handler is "onsourceclosed" with an extra "d". However, the event that is actually fired doesn't have the extra "d", so this event handler attribute doesn't do anything:
https://github.com/mozilla/gecko-dev/blob/b9384b091e901b3283ce24b6610e80699d79fd06/dom/media/mediasource/MediaSource.cpp#L536

Expected results:

It needs to be renamed to drop the trailing "d"

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → DOM: Events
Product: Firefox → Core
Component: DOM: Events → Audio/Video: Playback

I can see the failure in http://wpt.live/media-source/idlharness.window.html. Looks like it should be relatively straightforward to fix. Thanks for the report!

Assignee: nobody → jbauman
Severity: -- → S3
Priority: -- → P3
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Blocks: MSE
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2651c988ef75
MediaSource.prototype.onsourceclosed event handler attribute typo (trailing d). r=alwu,webidl,smaug
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: