1689257 - Remove or update probes expiring in Firefox 88: STARTUP_CACHE_REQUESTS

Status: RESOLVED FIXED

(Core :: XPConnect, task, P2)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 88 [1].

STARTUP_CACHE_REQUESTS
SCRIPT_PRELOADER_REQUESTS
SCRIPT_PRELOADER_WAIT_TIME
script.preloader.mainthread_recompile

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Chris Peterson [:cpeterson]]

Doug, does the Performance team still monitor these probes?

STARTUP_CACHE_REQUESTS
SCRIPT_PRELOADER_REQUESTS
SCRIPT_PRELOADER_WAIT_TIME
script.preloader.mainthread_recompile

Comment 2

[Alex Thayer [:alexical] (she/her)]

Not actively. They are not useless though, as debugging tools they could be helpful if we notice a regression in startup times. I would rather keep them around, but I wouldn't be heartbroken if we ripped them out.

(Leaving the needinfo on me in either case as I'll do the ripping out or extending - if any passersby have opinions please weigh in - otherwise I'll just extend these again in a week?)

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]: Tests depend on it:

• Marionette: TEST-UNEXPECTED-ERROR | js/xpconnect/tests/marionette/test_preloader_telemetry.py TestScriptPreloader.test_preloader_requests_histogram | JavascriptException: TypeError: can't access property "values", snapshot.parent.SCRIPT_PRELOADER_REQUESTS is undefined
• browser-chrome: startupcache/test/browser/browser_startupcache_telemetry.js

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 5

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1689257 - Update expiration for startup cache / script preloader probes r?mconley

These I could see us wanting to rip out at some point, so I am just going to
kick the can down the road.

Depends on D104838

Comment 6

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 9202613 [details]
Bug 1689257 - Update expiration for startup cache / script preloader probes r?mconley

Request for Data Collection Renewal

** This form is for the renewal of an existing, reviewed data collection.**

** All questions are mandatory.
You must receive Data Review from a
Data Steward
on a filled-out Request before shipping your renewed data collection.**

1. Provide a link to the initial Data Collection Review Request for this collection.

https://bugzilla.mozilla.org/show_bug.cgi?id=1364235#c25

2. When will this collection now expire?

In one year.

3. Why was the initial period of collection insufficient?

The probes contain performance information which continues to be useful. I do think rechecking whether we care about the things these are measuring in one year will be useful, however.

Comment 7

[Nicole Shadowen]

Comment on attachment 9202613 [details]
Bug 1689257 - Update expiration for startup cache / script preloader probes r?mconley

Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please land the patch (merge day is next Monday).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d910570475e
Update expiration for startup cache / script preloader probes r=mconley

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8d910570475e