Closed Bug 1689272 Opened 3 years ago Closed 3 years ago

Remove or update probes expiring in Firefox 88: startup.profile_selection_reason

Categories

(Toolkit :: Startup and Profile System, task)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- unaffected
firefox87 + fixed

People

(Reporter: telemetry-probes, Assigned: wlach)

References

Details

(Whiteboard: [probe-expiry-alert])

Attachments

(2 files)

The following Firefox probes will expire in the next major Firefox nightly release: version 88 [1].

startup.profile_selection_reason

What to do about this:

  1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
  2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Flags: needinfo?(rtestard)
Flags: needinfo?(jhollek)
Flags: needinfo?(gkaberere)
Flags: needinfo?(echo)
Flags: needinfo?(dtownsend)

Following the bug trail here, and in particular :mossop's commentary the last time this probe was renewed (https://bug1623406.bmoattachments.org/attachment.cgi?id=9135451), I can confirm the necessity of this probe for properly segmenting new acquisition still hold true.

Should we revisit setting the expiration condition? I.e. Is having no expiration an option?

Flags: needinfo?(echo)
Flags: needinfo?(gkaberere)

I can take this on.

(In reply to Edward Cho from comment #1)

Should we revisit setting the expiration condition? I.e. Is having no expiration an option?

:chutten is this allowed? I searched in firefox-source-docs and the data stewardship docs and couldn't find a concrete answer.

Assignee: nobody → wlachance
Flags: needinfo?(rtestard)
Flags: needinfo?(jhollek)
Flags: needinfo?(dtownsend)
Flags: needinfo?(chutten)

Permanent collections are permitted. It is recommended that they be covered by automated regression tests. Upgrading from expiring to permanent requires the use of the full Data Collection Review Request (not the renewal shortform) as we need to document the individual responsible for the probe over time (since it won't expire itself any more)

Flags: needinfo?(chutten)

(In reply to Chris H-C :chutten from comment #3)

Permanent collections are permitted. It is recommended that they be covered by automated regression tests. Upgrading from expiring to permanent requires the use of the full Data Collection Review Request (not the renewal shortform) as we need to document the individual responsible for the probe over time (since it won't expire itself any more)

Hmm, I don't think I want to take long-term responsibility for this probe. :) I am wondering if maybe we should just choose a longer time frame (say, 2 years) instead. By the end of that period, I imagine we'll be well into Firefox-on-Glean and hopefully our processes will have evolved enough that we can find someone who's willing to be a permanent owner for whatever replaces this.

(In reply to William Lachance (:wlach) (use needinfo!) from comment #4)

(In reply to Chris H-C :chutten from comment #3)
Hmm, I don't think I want to take long-term responsibility for this probe. :) I am wondering if maybe we should just choose a longer time frame (say, 2 years) instead. By the end of that period, I imagine we'll be well into Firefox-on-Glean and hopefully our processes will have evolved enough that we can find someone who's willing to be a permanent owner for whatever replaces this.

Backchanneling with :chutten, we don't feel it's worth circumventing our normal procedures on these things, which is to extend by a shorter interval. There's a very long list of people notified about this probe (and I'll add myself to the list), so I think this expiring unnoticed is very unlikely.

Attachment #9201450 - Flags: data-review?(chutten)

Comment on attachment 9201450 [details]
Data collection renewal request

Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

Is the data collection covered by the existing Firefox Privacy Notice?

Yes.


Result: datareview+

Attachment #9201450 - Flags: data-review?(chutten) → data-review+
Pushed by wlachance@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/646070c3de22
Increase the expiry of the profile selection reason telemetry probe r=chutten DONTBUILD

[Tracking Requested - why for this release]: toolkit/profile/xpcshell/* depends on it.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: