1689273 - Remove or update probes expiring in Firefox 88: wasm.compile_time_*

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P2)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 88 [1].

wasm.compile_time_baseline_us
wasm.compile_time_cranelift_us
wasm.compile_time_ion_us
js.run_time_us

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Lars T Hansen [:lth]]

Jan / Steven, js.run_time_us is probably in your court?

Comment 2

[Jan de Mooij [:jandem]]

I think the js.run_time_us probe was added in bug 1656638 for Wasm-related stuff.

Denis, as someone who has added Telemetry recently, how do you feel about keeping or removing this one?

Comment 3

[Denis Palmeiro [:denispal]]

I'm not sure what the original intention of the js.run_time_us probe was, but it seems to interact poorly with the scalar telemetry code causing some crashes when enabled. Personally, I think it may not be very valuable as a scalar probe anyways since you can have 1 ms callbacks and 300ms+ scripts reporting to the same scalar probe. It may be more useful instead to use a histogram that measures total JS executed during page load in ms, and maybe we can add similar histogram probes to specific callbacks that are interesting or a post page load JS measurement.

Comment 4

[Lars T Hansen [:lth]]

We should remove the wasm.* probes because we have no time to attend to their results at the moment; revisit later. Since the js._run_time_us probe has uncertain value and unclear ownership, we should remove that too.

Comment 5

[Lars T Hansen [:lth]]

Ryan, can you take care of this?

Comment 6

[Ryan Hunt [:rhunt]]

Attachment: Bug 1689273 - Remove expiring JS and wasm probes. r?lth

This commit removes the expiring probes:

• wasm.compile_time_baseline_us
• wasm.compile_time_cranelift_us
• wasm.compile_time_ion_us
• js.run_time_us

Execution runtime is still measured in the JS interpreter for still
active probes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5793c988794d
Remove expiring JS and wasm probes. r=lth

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5793c988794d