1689275 - Avoid notifying empty events to listener.

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Daisuke Akatsuka (:daisuke)]

If we call PlacesObserver.notifyListeners with empty events.
any registering listeners received the empty events.

See the following code.

PlacesObservers.addListener("page-visit", events => {
  console.log(events.length);
});
PlacesObservers.notifyListeners([]);

When run the code, we can see 0 in console.

I think we'd better avoid notifying the empty events to listeners.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1689275: Avoid notifying empty events.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83f9f1079744
Avoid notifying empty events. r=mak

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/83f9f1079744