1689317 - SAP - Paste event doesn't work for web components

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[martin.georgiev]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36

Steps to reproduce:

Open the following example.
https://codesandbox.io/s/ui5-webcomponents-forked-gdqfh?file=/src/index.js

1. Copy some text
2. Paste it in the input from the example

Actual results:

The paste event is not fired, which is most probably some bubbling issue. This works in other browsers.

Expected results:

The paste event should be fired.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Seems the paste event is composed in other browsers... What does the spec say?

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

AFAICT the clipboard spec does not say anything about shadow tree.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

nsCopySupport::FireClipboardEvent properly calls EventDispatcher::Dispatch (and thus the internal element properly gets the event) so it's indeed something about bubbling. The spec says:

6. If parent is a Window object, or parent is a node and target’s root is a shadow-including inclusive ancestor of parent, then:
   1. If isActivationEvent is true, event’s bubbles attribute is true, activationTarget is null, and parent has activation behavior, then set activationTarget to parent.
   2. Append to an event path with event, parent, null, relatedTarget, touchTargets, and slot-in-closed-tree.

It seems it should bubble to the host if I'm understanding it correctly.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689317 - Clipboard events should be composed. r=smaug,edgar

Comment 6

[Emilio Cobos Álvarez (:emilio)]

This is only about whether the event is composed. The event is composed in chrome / safari, so we should be able to fix it like the patch I just attached, but it'd be nice to have some sort of spec reference?

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Oh, TIL .composed 😅

Yes, the spec says it should be composed.

The paste event bubbles, is cancelable, and is composed.

... which also applies to copy and cut events.

Comment 8

[Tom S]

I think bug 1620420 reported this problem before.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5eeffaaf436
Clipboard events should be composed. r=smaug

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27387 for changes under testing/web-platform/tests

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d5eeffaaf436

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot