1689368 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.media.GeckoHLSResourceWrapper$Callbacks.onLoad(Native Method)]

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Emily Toop (:fluffyemily)]

Crash report: https://crash-stats.mozilla.org/report/index/38dc7f3a-3760-4d97-85c1-e0f2b0210128

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.gecko.media.GeckoHLSResourceWrapper$Callbacks.onLoad(Native Method)
	at org.mozilla.gecko.media.GeckoHlsPlayer$SourceEventListener.onLoadStarted(GeckoHlsPlayer.java:3)
	at org.mozilla.thirdparty.com.google.android.exoplayer2.source.MediaSourceEventListener$EventDispatcher.lambda$loadStarted$2$MediaSourceEventListener$EventDispatcher(MediaSourceEventListener.java:1)
	at org.mozilla.thirdparty.com.google.android.exoplayer2.source.-$$Lambda$MediaSourceEventListener$EventDispatcher$a5_BIn2eObPe9e9fkCFXKfJPwq4.run(Unknown Source:8)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Comment 1

[Byron Campen [:bwc]]

Seems really frequent.

Comment 2

[Jon Bauman [:jbauman:]]

John, any idea what might be going on here?

Comment 3

[John Lin [:jhlin][:jolin]]

I have been trying to reproduce this crash locally for quite some time but failed. After examining the reports and the source code, it seems to me that the only possible null Java object is the aUrl parameter though I cannot see how that could be null. Anyway, I will add a check in the Java callback method to avoid potential exceptions.

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1689368 - check state and URL before forwarding to native code. r?bryce

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b22705ac366
check state and URL before forwarding to native code. r=bryce

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9b22705ac366

Comment 7

[John Lin [:jhlin][:jolin]]

Comment on attachment 9215344 [details]
Bug 1689368 - check state and URL before forwarding to native code. r?bryce

Beta/Release Uplift Approval Request

• User impact if declined: Users encounter null pointer exception crashes when playing HLS contents sometimes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch performs a sanity check on input parameters before calling the native method.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9215344 [details]
Bug 1689368 - check state and URL before forwarding to native code. r?bryce

Approved for 88.0rc2, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/8f4af133907f

Comment 10

[Andrei Bodea[:andrei]]

Verified as fixed on Firefox 88.1.0 and latest Nightly 4/19 with Google Pixel 4 XL (11).
I used examples from https://www.toptal.com/apple/introduction-to-http-live-streaming-hls for HLS videos.