1689383 - The "Recommended by Pocket" section is no longer displayed on the latest Firefox Nightly for new profiles until a restart is made

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: ss of the issue.png

[Notes]:

• This issue is reproducible only on new Firefox profiles.

[Affected versions]:

• Firefox Nightly 87.0a1 - Build ID: 20210128094617

[Affected Platforms]:

• Windows 10 x64
• Mac 10.15
• Linux Mint 20

[Prerequisites]:

• Have a new Firefox profile with the "browser.search.region" pref set to "US" in the "about:config" page:

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and open a "New Tab".
2. Observed the displayed sections.

[Expected result]:

• The following sections are displayed:
  • In-content Search Bar
  • Top Sites
  • Recommended by Pocket
  • Highlights

[Actual result]:

• The "Recommended by Pocket" section is not displayed.

[Regression Window]:

• Considering the fact that this issue is not reproducible withe the Firefox Nightly build from 2021/01/ using the Mozregression tool I have managed to find the following regresion window:
  7:58.85 INFO: Last good revision: fe38d0f74425a27d23677eee7624777fa6ff9f25
  7:58.85 INFO: First bad revision: cf9e8638462a2e1583d4aa16bc216db1263cbc4a
  7:58.85 INFO: Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fe38d0f74425a27d23677eee7624777fa6ff9f25&tochange=cf9e8638462a2e1583d4aa16bc216db1263cbc4a

From the pushlog it seems that Bug 1688220 has caused this behavior.

[Additional Notes]:

• This issue is no longer reproducible after a browser restart.
• Attached a screenshot of the issue.

@Dao, could you please take a look over this issue?

Comment 1

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

Attached a screen recording of the issue.

Comment 2

[Dão Gottwald [:dao]]

So it sounds like there might be some code using the old notification name, "browser-region". However, I don't see anything suspicious here: https://searchfox.org/mozilla-central/search?q=browser-region&case=true

Comment 3

[Ciprian Muresan [:cmuresan], Ecosystem QA]

@thecount, could you please take a look at this?

Comment 4

[Scott [:thecount] Downe]

Looking

Comment 5

[Scott [:thecount] Downe]

I think this is caused by or an issue with any code looking at or using Region.REGION_UPDATED, which seems it was removed.

https://searchfox.org/mozilla-central/search?q=Region.REGION_UPDATED&path=

I'll see if I can verify that with my code that moving to the new const fixes it, but based on that search link above, I think it's hitting a few areas, not just Pocket, and should probably have a patch fixing all the uses.

Comment 6

[Scott [:thecount] Downe]

Attachment: Bug 1689383 - Fixing usage of region updated const

Comment 7

[Scott [:thecount] Downe]

I have a fix, but I think it should be reviewed by either dale or dao? I'll add them as reviewers.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7b773722d7b
Fixing usage of region updated const r=daleharvey

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e7b773722d7b

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (87.0a1 Build ID - 20210131211743) installed on Windows 10 x64, Windows 7 x64, and Windows 8.1 x32. Now, I can confirm that the "Recommended by Pocket" section is successfully displayed.