Closed Bug 1689410 Opened 8 months ago Closed 8 months ago

Fix Zoom controls styling in the Proton AppMenu

Categories

(Firefox :: Menus, defect, P3)

defect

Tracking

()

VERIFIED FIXED
87 Branch
Tracking Status
firefox87 --- verified

People

(Reporter: mconley, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-hamburger-menu])

Attachments

(2 files)

Currently, the Zoom controls in the Proton AppMenu have:

  1. Unusual start-side indentation
  2. No icons for the +, - and fullscreen controls
  3. A ring and shading around the zoom level that we'd like to remove.

Work to do:

  1. Re-use the existing icon assets for now. This might involve re-jigging some of the CSS I added in bug 1688744 to allow for icons on some toolbaritems.
  2. Remove the ring and shading around the zoom level display.
  3. Eliminate the start-side padding of the toolbaritem.

This work should be self-contained to the Proton AppMenu, and should not impact the currently shipping AppMenu.

Attachment #9199838 - Attachment description: image.png → What's currently in Nightly
Severity: -- → S3
Type: task → defect
Priority: -- → P3
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc3cfadd11f1
Fix zoom controls styling in proton appmenu. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

I can reproduce this bug on Fx 87.0, with proton on, using Win 10.
Verified - Fixed in latest Nightly 90.0a1 (2021-04-19), Fx 89.0b2, Fx 88.0 and Fx 87.0b9,with proton on, using Windows 10x64 and Mac 11.

Status: RESOLVED → VERIFIED

I can reproduce this bug on Fx 87.0, with proton on, using Win 10.
Verified - Fixed in latest Nightly 90.0a1 (2021-04-19), Fx 89.0b2, Fx 88.0 and Fx 87.0b9,with proton on, using Windows 10x64 and Mac 11.

You need to log in before you can comment on or make changes to this bug.