1689410 - Fix Zoom controls styling in the Proton AppMenu

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: What's currently in Nightly

Currently, the Zoom controls in the Proton AppMenu have:

1. Unusual start-side indentation
2. No icons for the +, - and fullscreen controls
3. A ring and shading around the zoom level that we'd like to remove.

Work to do:

1. Re-use the existing icon assets for now. This might involve re-jigging some of the CSS I added in bug 1688744 to allow for icons on some toolbaritems.
2. Remove the ring and shading around the zoom level display.
3. Eliminate the start-side padding of the toolbaritem.

This work should be self-contained to the Proton AppMenu, and should not impact the currently shipping AppMenu.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 1689410 - Fix zoom controls styling in proton appmenu. r=mconley!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc3cfadd11f1
Fix zoom controls styling in proton appmenu. r=mconley

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dc3cfadd11f1

Comment 4

[Raluca Popovici, Desktop QA]

I can reproduce this bug on Fx 87.0, with proton on, using Win 10.
Verified - Fixed in latest Nightly 90.0a1 (2021-04-19), Fx 89.0b2, Fx 88.0 and Fx 87.0b9,with proton on, using Windows 10x64 and Mac 11.

Comment 5

[Raluca Popovici, Desktop QA]

I can reproduce this bug on Fx 87.0, with proton on, using Win 10.
Verified - Fixed in latest Nightly 90.0a1 (2021-04-19), Fx 89.0b2, Fx 88.0 and Fx 87.0b9,with proton on, using Windows 10x64 and Mac 11.