1689567 - Add telemetry and handle "disconnected" events for infobar_message

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Andrei Oprea [:andreio]]

If we use infobar_message only inside a tab (not global) there is an additional event disconnected that happens if the tab gets closed and dismisses the infobar.
This case is currently not handled.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1689567 - Add telemetry and handle disconnected events for infobar_message

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5fdf5d840af
Add telemetry and handle disconnected events for infobar_message r=nanj

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a5fdf5d840af

Comment 4

[Robert Martin [:romartin], Ecosystem QA]

I have verified that a "DISMISSED" ping is displayed in the "Browser Console" using Firefox Nightly 88.0a1 (Build ID: 20210223085042) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 with the following steps:

[Prerequisites]:

• Have the pref browser.ping-centre.log value set to true.
• Have the pref browser.newtabpage.activity-stream.asrouter.devtoolsEnabled value set to true.
• Have the pref browser.newtabpage.activity-stream.asrouter.providers.onboarding value set to {"id":"onboarding","type":"local","localProvider":"CFRMessageProvider","enabled":true,"exclude":[]}.
• Have the Browser Console opened.

[Steps to Reproduce]:

1. Navigate to the "about:newtab#asrouter" page.
2. Select the "onboarding" option from the "Show messages from" drop-down menu.
3. Change the "type" value from "global" to "tab" from the "INFOBAR_ACTION_86" section.
4. Click the "Modify" button from the "INFOBAR_ACTION_86" section.
5. Close the "about:newtab#asrouter" page and observe the "Browser Console".

[Expected result]:

• A Telemetry Ping is displayed with an "event": "DISMISSED" is displayed.