16896 - migration will fail if the users 4.x account was a migrated 3.x account

Status: VERIFIED FIXED

(Core Graveyard :: Profile: Migration, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

if you ran 3.x, and then used 4.x to upgrade, you'd end up with a 4.x profile
registry that had this as an entry

<profile name>,alias to the the single 3.x netscape profile directory, something
like "Preferences:Netscape f"  (f is really some special character)

so after the 3.x to 4.x migration, you have

Preferences:Netscape Users:(alias to Preferences:Netscape f named <profile name>"

when you then migrate to 5.x, it fails.

the extra level of indirection seems to cause the failure

adding danm and sdagley to the cc list, they are the ones who found this.

it's mac only.

Comment 1

[racham]

Accepting the bug.

Comment 2

[racham]

Doug, can you help us understand what's causing this problem?

Comment 3

[Doug Turner (:dougt)]

where is the code that does this coping?  is it set to resolve aliases?

Comment 4

[racham]

The code is in nsPrefMigration.cpp 
(http://lxr.mozilla.org/seamonkey/source/profile/pref-migrator/src/nsPrefMigrati
on.cpp#1379). It is using CopyToDir() fo filespec. Does that do resolve on 
aliases ?

Comment 5

[Doug Turner (:dougt)]

here is my best guess without debug (and with less then 3 hours sleep).  Change 
line:

http://lxr.mozilla.org/seamonkey/source/profile/pref-migrator/src/nsPrefMigrati
on.cpp#1392

to pass PR_TRUE to resolve alias.

  

Comment 6

[racham]

We have pushed having to deal with 4.0x profile information migration to post 
beta, as the number of the users whi will be affected will be significantly 
low. This bug is a mac specific bug suffering from alias problems in the 
process having a 3.x->4.x->5.0 profile information transition. Will look into 
this in post-beta. Setting TFV to M15.

Setting value in nsProfileMigration.cpp to PR_TRUE will probably be a part of 
final solution. At this point, the app is not reaching that point. More debuggin 
g needed.

Comment 7

[racham]

Passing PR_TRUE to resove alias didn't cut it. Not doing it in beta3 unless
product marketing wants us to fix this badly. Moving the milestone to future.

Comment 8

[(not reading, please use [e-mail] instead)]

adding waldemar to the cc list.

Comment 9

[Waldemar Horwat]

I think we should either fix it or release note a workaround for RTM.

Comment 10

[Waldemar Horwat]

See also bugs 53109 and 52181.  The dumb-user-visible effect of this bug is that 
a user's IE bookmarks are migrated but 4.7.5 bookmarks are not, and it's not 
clear why.

Comment 11

[scottputterman]

marking rtm-. Not too many people will run into this.

Comment 12

[Waldemar Horwat]

We're already getting complaints about this in reviews.

Comment 13

[Conrad Carlen (not reading bugmail)]

I have found what causes this and it's in nsProfileAccess.cpp. It has to do with
the directory name being converted between unicode and ISO Latin and the special
character gets lost (converted to a '.') in that case. Probably not too hard to fix.

Comment 14

[racham]

-> Conrad.

Comment 15

[Conrad Carlen (not reading bugmail)]

I believe this is fixed now (as a happy side-affect of some other profile work).
I say "beleive" because I know the ? (option-f) character gets read correctly. I
have tried this with a registry Waldemar sent me which pointed to a profile dir
which contained that char. Whether the contents of the dir would have been
migrated, I don't know. Can somebody verify?

Comment 16

[Grace Bush]

I will try to test this- looking for 3.0 version to install

Comment 17

[lchiang]

Grace - check with allclientqa mailing list or slip pages.  I am sure we have
this somewhere.

Comment 18

[Grace Bush]

ckritzer gave me a copy
Ran Navigator 3.x- set bookmarks, mail identity, cookies
Upgraded to 4.0x and above items were 'migrated' 
Upgraded to 4.74 and above items were usable.
Installed 6.0 (trunk build from 1229) and this 3.0->4.0>4.7 profile was silently 
migrated since it was single profile.  N6 came up with bookmarks, cookies and 
mail
One thing to note. I had to install N6 to trigger the migration - just drag/drop 
Profile Manager icon did not show this old profile in Profile Manager list for 
selection (empty list) which I found problematical.

Comment 19

[Grace Bush]

oops,  dragged /dropped Profile Migration icon and it worked.  Conrad, I think 
this is fixed,  tested and verified with 2001010209 build on Mac 9.0

Comment 20

[Conrad Carlen (not reading bugmail)]

Grace - based on what you said, I'm marking as fixed. Can you verify? Sounds
like you have already but not marked as such.

Comment 21

[Grace Bush]

verify as noted above

Comment 22

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/bb45d2fab389
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16896: Integrate new MediaSession API to nightly or debug builds (https://github.com/mozilla-mobile/fenix/pull/16909)