1689631 - onabsolutedeviceorientation should be ondeviceorientationabsolute

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P2)

Description

[Philip Jägenstedt [:foolip]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_1_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36

Steps to reproduce:

Compare the spec and Gecko's Web IDL for the event handler attribute:
https://w3c.github.io/deviceorientation/#deviceorientationabsolute
https://github.com/mozilla/gecko-dev/blob/ee110bca4d6cc8892bfca099c15ebb0fc8814816/dom/webidl/Window.webidl#L494

Actual results:

The name is different, with "absolute" up front instead of at the end.

Expected results:

Per spec, the name of the event hander attribute should be "ondeviceorientationabsolute"

I have not been able to figure out if the name of the event fired is also wrong, if it's "absolutedeviceorientation" instead of "deviceorientationabsolute".

Comment 1

[Philip Jägenstedt [:foolip]]

There are some failures in WPT that are due to this:
https://wpt.fyi/results/orientation-event/idlharness.https.window.html?run_id=5697912233263104&run_id=5749281250082816&run_id=5730715079540736

Comment 2

[Timea Cernea [:tbabos][inactive]]

Moving this over to DOM:Events, if this is not the right component please move it over to the correct one.

Comment 3

[John Dai[:jdai]]

Hi Esawin,
Could you help to take a look? It seems that the specification has been changed deviceorientationabsolute event handler attribute name. Thank you.

Comment 4

[Eugen Sawin [:esawin]]

@smaug: do you know who can take this? I'm not a DOM peer, we just happened to need it for Android VR back in the days.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I wonder why the spec was changed. That was of course very much breaking change.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

But anyone could take this, I think. Should be about replacing the name.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 8

[Mark Sibly]

Hi, a quick grep suggests this is probably just a simple rename job and would be happy to do it, although I'm not familiar with this particular code.

Comment 9

[fanie]

Attachment: Bug 1689631 - Renamed onabsolutedeviceorientation to ondeviceorientationabsolute. r?freddyb,smaug

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

https://github.com/w3c/deviceorientation/commit/c93616036b6f8aa17557bd57cced7acca378448f changed this. Doesn't explain why.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3acec9a0338b
Renamed onabsolutedeviceorientation to ondeviceorientationabsolute. r=smaug

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3acec9a0338b