168976 - Remove RsaPubModulus from nsIX509Cert

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Kai Engert [:KaiE:]]

I'm in the process of adding documentation to nsIX509Cert.
I see it contains a readonly attribute named rsaPubModulus.

Our implementation always returns the string "not yet implemented".

None of our code actually accesses that attribute.

I propose to remove this completely from the interface and the implementation.

Comment 1

[Javier Delgadillo]

Is there any other way to get at the public key material for a cert?  Displaying
info about the public key is something embeders and/or mozilla may want to do
one day.

Comment 2

[Kai Engert [:KaiE:]]

If we don't currently have implemented a way to obtain that information, then we
don't need to do that before a freeze. We can do that at a later time using the
following strategy:

- add a new separate interface
- make the implementation of nsIX509Cert QIable to the new interface

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Patch v1

Javi, can you please review?

Comment 4

[Javier Delgadillo]

Comment on attachment 99679 [details] [diff] [review]
Patch v1

r=javi

Comment 5

[Kai Engert [:KaiE:]]

Alec, can you please review?

Comment 6

[rpotts (gone)]

Comment on attachment 99679 [details] [diff] [review]
Patch v1

sr=[e-mail]

Comment 7

[Kai Engert [:KaiE:]]

Fixed on trunk.

Comment 8

[John Unruh]

Verified per kaie's comment.