1689761 - Update toolbar focus styling to match Proton styles.

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now toolbar focus styling has outline color matching currentColor, however this would not be consistent with Proton styling for focus. For light them the focus outline color should be #0061E0 and for dark theme #00DDFF.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1689761 - provide focus-outline color experimental theme variable for Alpenglow. r=ntim

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1689761 - define common focus outline style for toolbars. r=ntim

Depends on D103820

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1689761 - update toolbar focus outline color from currentColor to proton colors (theme dependent). r=jaws

Depends on D103821

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1689761 - update tab keyboard focus to Proton styles. r=jaws

Depends on D103822

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c88585f0fe4
provide focus-outline color experimental theme variable for Alpenglow. r=desktop-theme-reviewers,ntim
https://hg.mozilla.org/integration/autoland/rev/e63c5a6932e3
define common focus outline style for toolbars. r=desktop-theme-reviewers,ntim
https://hg.mozilla.org/integration/autoland/rev/232a4e735cdc
update toolbar focus outline color from currentColor to proton colors (theme dependent). r=jaws
https://hg.mozilla.org/integration/autoland/rev/8c53818717a1
update tab keyboard focus to Proton styles. r=jaws

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 5 changesets (Bug 1689761, Bug 1691793) for causing bustages in nsLookAndFeel.mm

Backout link: https://hg.mozilla.org/integration/autoland/rev/a65883accdf6e90fae4fe5e85ab43e950e50f649

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=8c53818717a1fb7a9925b8ac612d504167dabced&selectedTaskRun=DL_cEdEOQU6OKV1Ts0c13g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=329505684&repo=autoland&lineNumber=40113

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71f820db5357
provide focus-outline color experimental theme variable for Alpenglow. r=desktop-theme-reviewers,ntim
https://hg.mozilla.org/integration/autoland/rev/b75cfd88c6b2
define common focus outline style for toolbars. r=desktop-theme-reviewers,ntim
https://hg.mozilla.org/integration/autoland/rev/abd5c7e3aa80
update toolbar focus outline color from currentColor to proton colors (theme dependent). r=jaws
https://hg.mozilla.org/integration/autoland/rev/f838b9f64e6a
update tab keyboard focus to Proton styles. r=jaws

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/71f820db5357
https://hg.mozilla.org/mozilla-central/rev/b75cfd88c6b2
https://hg.mozilla.org/mozilla-central/rev/abd5c7e3aa80
https://hg.mozilla.org/mozilla-central/rev/f838b9f64e6a

Comment 9

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We can confirm the figma design is respected on Fx 89.