1689799 - SVG textPath elements moved on top of each other if they do not have a line break

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Rico Sonntag]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

I have created an SVG using D3.js library. If an SVG element contains a <text> element with several <textPath> elements and these are transmitted, e.g. packed by compression, the elements are displayed on top of each other. If a line break is inserted after each <textPath> element, the display is correct again.

Please compare the provided fiddles. They contain exactly the same SVG code only differs in the formatting of the <text> block. If not linebreaks provided the SVG is not rendered correctly.

Actual results:

Firefox 85 breaks the rendering of the SVG. It was working until version 84.

See the following fiddle with the actual result:
https://jsfiddle.net/fvnbtzxw/

Expected results:

The <textPath> elements should behave as before in Firefox 84.

See the following fiddle with the expected result: https://jsfiddle.net/c25em60q/

Comment 1

[Rico Sonntag]

This error was not happening in Firefox 84.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case from reporter.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Mozregression says:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7f5fad730196dc402439111f3b553624f5b842fc&tochange=4410515e06c75b927687488f1707dc36b1c838ca

Comment 4

[Robert Longson [:longsonr]]

Attachment: Bug 1689799 - Ensure we move to the next path when displaying multiple adjacent textPaths

reverts part of bug 1678756

Comment 5

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=a50ee7db05d2ae5dee7609d75c847014da940cdb

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/434d94e939e9
Ensure we move to the next path when displaying multiple adjacent textPaths r=emilio

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/434d94e939e9

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 9

[Robert Longson [:longsonr]]

Comment on attachment 9200233 [details]
Bug 1689799 - Ensure we move to the next path when displaying multiple adjacent textPaths

Beta/Release Uplift Approval Request

• User impact if declined: SVG files with multiple adjacent textPath elements will be misrendered
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This reverts part of the change from bug 1678756 so we've had this line in prior versions already.
• String changes made/needed: none

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9200233 [details]
Bug 1689799 - Ensure we move to the next path when displaying multiple adjacent textPaths

Approved for 86 beta 5, thanks.

Comment 11

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cf58aa3c1975