1689830 - Stop using <deck> for .wizard-page-box

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/rev/868935867c6241e1302e64cf9be8f56db0fd0d1c/toolkit/content/widgets/wizard.js#72-74

The <deck> custom element is not going to work there, because it considers DOM children (slot) unlike nsDeckFrame which considers frame tree children (wizardpage).

Adding hacks into the <deck> CE is probably not worth it given that they'll need to cover CSS styling, or the mutation observer. A customized-slot element is also not worth maintaining either.

Best path is probably to just manually implement the showing/hiding of pages in the wizard CE.

Comment 1

[Mats Palmgren (inactive)]

Attachment: wizard mockup

Fwiw, you can use any display value on <slot>, so we could remove the <deck> there and use display:grid directly on the slot itself if that helps. Given that <wizard> already has a "page index", maybe can use that instead of the <deck>'s selectedIndex?

Here's a mockup of that idea...

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1689830 - Stop using <deck> for .wizard-page-box.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a17d14515b6
Stop using <deck> for .wizard-page-box. r=bgrins

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3a17d14515b6