1689930 - Fix layout in the about dialog to match mock-ups and make the version number easier to spot

Status: NEW

(Firefox :: General, defect)

Description

[aoia7rz7l]

Tested in 86.0b3.

STR:

1. Open the About Firefox dialog via Help > About Firefox.

Expected Behavior:
Version number in About Firefox dialog is displayed in bold (as in 85.0).

Actual Behavior:
Version number in About Firefox dialog is no longer displayed in bold.

The Updates disabled by your system administrator message was also moved from below the version number to above it. In this new position, there is in fact zero spacing between the message and the Firefox Browser Developer graphic.

Comment 1

[:Gijs (out for now; he/him)]

Bernard, could you take a look?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1660848

Comment 3

[Pascal Chevrel:pascalc]

Marking as fix-optional but if a safe fix like a one liner css patch comes up, we could take it in an uplift to beta.

Comment 4

[Bernard Igiri]

Hello aoia7rz7l, could please add a screenshot of the "Updates disabled by your system administrator" message? That would help a lot. Thank you.

Comment 5

[aoia7rz7l]

Attachment: aboutDialog

Comment 6

[:Gijs (out for now; he/him)]

Reporter; thanks, but what OS is the screenshot from? You've cropped out the titlebar and it's not in any of the comments. I cannot reproduce the lack of spacing on macOS or Windows 10 (though I checked on Nightly - in theory, the different word mark may make a difference, but the image sizes between nightly and devedition are the same).

Markus, was the design's removal of bold font for the version number deliberate? There's no bold font in the mocks.

Comment 7

[Markus Jaritz [:designakt] (UX)]

(In reply to :Gijs (he/him) from comment #6)

was the design's removal of bold font for the version number deliberate? There's no bold font in the mocks.

Yes it was as we are shifting the focus from the version number to the update-state of your browser. (eg checking, loading, restart, up to date)
I did not account for: updates disabled. But it should just work in the same pattern.
Getting to spacing as showing in the mockup would help with better readability:

• more space between logo and update status
• no space between update status and version number
• more space between version and help links

Comment 8

[aoia7rz7l]

Attachment: aboutDialog2

I have retested this in beta and nightly and cannot reproduce there either. This seems to be a devedition-specific issue and is unrelated to the Updates disabled by your system administrator message.

Comment 9

[Daniel Bodea [:danibodea]]

I can confirm the regressor provided in comment 2 (for the version number in the About window not being bold). Mozregression results:

2021-02-05T15:08:20.588000: DEBUG : Found commit message:
Bug 1660848 - Add a check for updates option to application menus r=fluent-reviewers,jaws,harry,Gijs,flod,mkaply

Adding a check for updates option to the application menu, changing the about dialog styling to match the mockup, and adding a minimum delay to the checking for updates message.

Differential Revision: https://phabricator.services.mozilla.com/D95195

2021-02-05T15:08:20.588000: DEBUG : Did not find a branch, checking all integration branches
2021-02-05T15:08:20.591000: INFO : The bisection is done.
2021-02-05T15:08:20.593000: INFO : Stopped

If this issue requires verification in the future, please NI me and provide the exact design I would need to verify. Thank you.

Comment 10

[aoia7rz7l]

The spacing part of this issue was fixed in bug 1697069.