Closed Bug 1689933 Opened 10 months ago Closed 10 months ago

Force commit_span inline

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(1 file)

No description provided.

commit_span is an extremely hot and extremely short function that seems to show
up in many profiles. For some reason the optimizer doesn't choose to inline it,
when the cost of a function call is significant relative to the small amount of
critical work the function does. Force this inline so that we don't waste perf
calling this as a function.

Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce5e2f5f521e
force commit_span inline. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

== Change summary for alert #28591 (as of Tue, 02 Feb 2021 15:59:25 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
8% rasterflood_gradient windows10-64-shippable-qr e10s stylo webrender-sw 404.58 -> 436.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28591

Regressions: 1700520
You need to log in before you can comment on or make changes to this bug.