1689933 - Force commit_span inline

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1689933 - force commit_span inline. r?jrmuizel

commit_span is an extremely hot and extremely short function that seems to show
up in many profiles. For some reason the optimizer doesn't choose to inline it,
when the cost of a function call is significant relative to the small amount of
critical work the function does. Force this inline so that we don't waste perf
calling this as a function.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce5e2f5f521e
force commit_span inline. r=jrmuizel

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ce5e2f5f521e

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #28591 (as of Tue, 02 Feb 2021 15:59:25 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
8%	rasterflood_gradient		windows10-64-shippable-qr	e10s stylo webrender-sw	404.58 -> 436.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28591