Closed
Bug 1689933
Opened 3 years ago
Closed 3 years ago
Force commit_span inline
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•3 years ago
|
||
commit_span is an extremely hot and extremely short function that seems to show
up in many profiles. For some reason the optimizer doesn't choose to inline it,
when the cost of a function call is significant relative to the small amount of
critical work the function does. Force this inline so that we don't waste perf
calling this as a function.
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce5e2f5f521e force commit_span inline. r=jrmuizel
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
|
||
Comment 4•3 years ago
|
||
== Change summary for alert #28591 (as of Tue, 02 Feb 2021 15:59:25 GMT) ==
Improvements:
| Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|---|
| 8% | rasterflood_gradient | windows10-64-shippable-qr | e10s stylo webrender-sw | 404.58 -> 436.33 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28591
|
|
||
Updated•3 years ago
|
Keywords: perf-alert
You need to log in
before you can comment on or make changes to this bug.
Description
•