1689993 - Non-native theme form elements font size is 13px, should be 13.3333px

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0 ID:20210201094443

With widget.disable-native-theme-for-content set to true, form elements such as buttons, input and select fields have a default font size of 13px on Linux.

If I activate widget.disable-native-theme-for-content on Windows, these same elements have a font size of 13.3333px. This 13.3333px size is also the default for Chromium browsers (Linux and Windows).

For consistency of Firefox across platforms and for consistency with other browsers, we should have the same default font size of 13.3333px

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689993 - Make the non-native-theme font-size adjustment be the same in all platforms. r=spohl,mstange

The Windows code was going into effect even if non-native-theme was
enabled, so right now nnt does something different in windows from other
platforms.

I think we should make it match Windows, which also matches Chromium on
non-Windows platforms too.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd41d4c8c4fa
Make the non-native-theme font-size adjustment be the same in all platforms. r=spohl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a16a70db69d7
Tweak a reftest annotation now that native and non-native theme fail similarly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a6d78effab1
One more fuzzy pixel in non-webrender because of the bigger font-size.

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fd41d4c8c4fa

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a16a70db69d7
https://hg.mozilla.org/mozilla-central/rev/0a6d78effab1