169003 - merge mozbrwsr into appcomps

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Alec Flett]

The mozbrwsr dll is only 16k, and history has shown that DLL overhead is
somewhere around 12k on disk (and 30k in memory) so I'm merging it into appcomps
in an effort to reduce bloat.

My guess is that appcomps will get about 4k bigger... since this DLL goes away,
thats both a 12k win, and one less DLL to load at startup.

patch forthcoming.

Comment 1

[Alec Flett]

Attachment: merge mozbrwsr into appcomps

Here's the patch.

the one thing I had to do was move the nsBrowserStatusHandler class declaration
into the header file, so that the module could get at the constructor for the
class.

Can I get an r=blake, sr=jag?

Comment 2

[jag (Peter Annema)]

So what's the gain?

Comment 3

[jag (Peter Annema)]

I was a bit too quick with the submit button there. I wanted it to read:

So what's the measured gain?

Comment 4

[Alec Flett]

I haven't checked DLL size on a release build yet, I'll post when I do. (But can
I still get a review? There's no reason this should be in its own dll)

Comment 5

[Alec Flett]

ok, I threw this onto a release build that was a few days old, here were the
results:

before:
32      components\mozbrwsr.dll
284     components\appcomps.dll
316     total

after:
292     components\appcomps.dll

so we see that appcomps.dll went up by 8k, and the total size went down by 24k.

One thing I don't QUITE get is that on my nightly install from yesterday (where
I got the number from comment 0) mozbrwsr is 16k, and appcomps is 271k... I'm
not quite sure what the difference is, between my release build and the nightly
build, but in any case we're of course seeing a net gain of at least 8k,
probably 12k, and since there is a fixed cost runtime overhead of about 30k per
dll, this is a great gain for us.

Comment 6

[jag (Peter Annema)]

Comment on attachment 99394 [details] [diff] [review]
merge mozbrwsr into appcomps

Cool. Could it be that your one build is running with symbols (MOZ_PROFILE)?

sr=jag

Comment 7

[Alec Flett]

Attachment: the mac project changes

this is just the mac project changes required to make this build

Comment 8

[jag (Peter Annema)]

Comment on attachment 99455 [details] [diff] [review]
the mac project changes

sr=jag

Comment 9

[Brian Ryner (not reading)]

Comment on attachment 99394 [details] [diff] [review]
merge mozbrwsr into appcomps

r=bryner

Comment 10

[Brian Ryner (not reading)]

Comment on attachment 99455 [details] [diff] [review]
the mac project changes

r=bryner

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

shouldn't this be marked fixed now?
(was checked in 09/19/2002 12:00 by alecf%netscape.com)

Comment 12

[Alec Flett]

geez give me a few minutes already.