1690134 - Intermittent in browser_history_persist.js (wrong URL: got about:blank, should be about:robots) in fission

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Bug 1673617 causes a new intermittent in fission only, where the URL is incorrect occasionally (~30% on Try, <1% locally).

TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_history_persist.js | Should be the right URL - Got "about:blank", expected "about:robots"
often but not always followed by:
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_history_persist.js | Should be two history entries - Got 1, expected 2
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_history_persist.js | Uncaught exception - [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistory.getEntryAtIndex]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_history_persist.js :: check_history_default_persisted :: line 155" data: no]
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_history_persist.js | Found an unexpected tab at the end of test run: about:blank -

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1673617

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission M7 for re-enabling this test.

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/browser/components/sessionstore/test/browser.ini#115-116

[browser_history_persist.js]
skip-if = fission # Bug 1690134

Comment 3

[Andrew McCreight [:mccr8]]

I'm taking a look at this, though I'm not familiar with session store.

Comment 4

[Andrew McCreight [:mccr8]]

It sounds like this might be fixed by Kashav and Andreas's work on session restore, so I'll assign it to Kashav for enabling.

Comment 5

[u608768]

Will enable this in bug 1597499.

Comment 6

[u608768]

Happening again, particularly often with the patches from bug 1702055. I think I have a fix.

Comment 7

[u608768]

Attachment: Bug 1690134 - Fix flakiness in browser_history_persist.js, r?annyG

Waiting for the about:robots load explicitly ensures we don't proceed until all
history changes have fully propagated.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/252f1d727e0d
Fix flakiness in browser_history_persist.js, r=annyG

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/252f1d727e0d