1690154 - Enable symbols for autoland linux builds to enable pernosco self-serve reproductions

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, enhancement)

Description

[Andrew Sutherland [:asuth] (he/him)]

It is quite common for failed landings on autoland to uncover failures that were not previously known. Pernosco has a documented mechanism for generating reproductions from taskcluster job failures of individual tests but they depend on the task having generated "target.crashreporter-symbols-full.EXTENSION" artifacts. Per discussion with :khuey this logic in taskcluster/taskgraph/transforms/build.py is the reason, only enabling the symbols for RELEASE_PROJECTS and "try" but not autoland.

This enabling would only be necessary for platforms supported by pernosco, which means linux64 I believe.

Comment 1

[Aki Sasaki (not active)]

:gsvelto, as Crash Reporting module owner, are there are any concerns with turning on full crashreporter symbols on autoland?

Comment 2

[Mike Hommey [:glandium]]

As long as we don't upload them to the symbol server, the only concerns would be about artifact size on taskcluster's s3 and build times (although the latter shouldn't be too much of a concern).

Comment 3

[Mike Hommey [:glandium]]

Implementation-wise, adding MOZ_ENABLE_FULL_SYMBOLS: "1" to the relevant tasks's environment variables in taskcluster/ci/build/linux.yml should do it (that would also enable it on central, beta, release, etc. after it rides the train, but I don't see why it shouldn't).

Comment 4

[Kyle Huey [:khuey]]

From our perspective this is basically a cost/benefit tradeoff for Mozilla and whether it's worth the cost of storing those files in s3.

Comment 5

[Gabriele Svelto [:gsvelto]]

Like Mike said if the symbols aren't uploaded to the symbol server then the only additional costs are for storage on S3. I don't have hard numbers about this, but given that the number of try builds should exceed autoland by a pretty large margin I guess the increase in storage requirements should be reasonable (especially given this is only for linux64).

Comment 6

[Aki Sasaki (not active)]

Attachment: Bug 1690154 - autoland linux64 crashsymbols. r=#taskgraph-reviewers

Comment 7

[Aki Sasaki (not active)]

https://phabricator.services.mozilla.com/D103818 appears to create an upload symbols task as well. Is that problematic?

Comment 8

[Aki Sasaki (not active)]

Attachment: autoland-onpush.json.diff

This is the diff in the taskgraph between central and central-with-this-patch, using autoland parameters.

Comment 9

[Gabriele Svelto [:gsvelto]]

(In reply to Aki Sasaki [:aki] (he/him) from comment #7)

https://phabricator.services.mozilla.com/D103818 appears to create an upload symbols task as well. Is that problematic?

Yes, that will upload the symbols to the symbol server for every build.

Comment 10

[Aki Sasaki (not active)]

Attachment: Bug 1690154 - add MOZ_ENABLE_FULL_SYMBOLS to some linux64 builds. r=#taskgraph-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a93520b8a17
add MOZ_ENABLE_FULL_SYMBOLS to some linux64 builds. r=glandium

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3a93520b8a17