1690156 - [wpt-sync] Sync PR 27435 - Add feature to disallow 3rd party origin subframe JS dialogs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27435 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27435
Details from upstream follow.

b'Carlos IL <[e-mail]>' wrote:

Add feature to disallow 3rd party origin subframe JS dialogs

Test: Covered by WPT, except for alert (which can't be tested in WPT).

Bug: 1065085
Change-Id: I8a58be63014c7893ab864d3582516a9eddbf5e25
Reviewed-on: https://chromium-review.googlesource.com/2645693
WPT-Export-Revision: c83583bdfded6ef8a542e0dbc12262ede9588a82

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=92a7e38a022da8ef46fcc1e5a6a5618802565212

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 2
ERROR : 2

Chrome

TIMEOUT: 2

Safari

ERROR : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/webappapis/user-prompts/cannot-show-simple-dialogs/confirm-different-origin-frame.sub.html: ERROR [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], OK [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: TIMEOUT, Safari: ERROR)
/html/webappapis/user-prompts/cannot-show-simple-dialogs/prompt-different-origin-frame.sub.html: ERROR [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], OK [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: TIMEOUT, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d2b8f163db8
[wpt PR 27435] - Add feature to disallow 3rd party origin subframe JS dialogs, a=testonly
https://hg.mozilla.org/integration/autoland/rev/02b805e74c3a
[wpt PR 27435] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ed6bb08c133
[wpt PR 27435] - Add feature to disallow 3rd party origin subframe JS dialogs, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ae584604d037
[wpt PR 27435] - Update wpt metadata, a=testonly

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6ed6bb08c133
https://hg.mozilla.org/mozilla-central/rev/ae584604d037