1690173 - about:restartrequired doesn't clear after restarts (in fission)

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

about:restartrequired?e=restartrequired&u=about%3Ablank&c=UTF-8&d=%20 stays visible in the select tab after selecting Restart Nightly. I am able to open a new tab and browse with it.

Using fission, on mac. There was another nightly instance running in a different profile at the start. I exited that, no change in behavior. I opened About Nightly, and let it download and apply an update, and there was no change.

Not sure fission is a cause here

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Turning off fission didn't change it

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

The summary talks about fission, but comments 0 and 1 contradict that.
"Not sure fission is a cause here" ... "Turning off fission didn't change it".

So is this a fission bug or not?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

This bug is likely caused by sessionstore recording session history entries for about:restartrequired, instead of ignoring them, which is likely caused by SHIP's general issues around recording history entries for error pages.

It sounds vaguely like perhaps SHIP is building history with the document URI instead of the nsDocShell's current location?

Comment 4

[Chris Peterson [:cpeterson]]

Nika says document URI always matches nsDocShell's current location except for error pages (like about:restartrequired).

Assigning to Peter because he's been looking at session restore of other error pages.

Tracking for Fission M7 Beta.

Comment 5

[Peter Van der Beken [:peterv]]

(In reply to Nika Layzell [:nika] (ni? for response) from comment #3)

This bug is likely caused by sessionstore recording session history entries for about:restartrequired, instead of ignoring them, which is likely caused by SHIP's general issues around recording history entries for error pages.

I tried to artificially recreate this by manually calling docShell.displayLoadError(Cr.NS_ERROR_BUILDID_MISMATCH, …); and I can't reproduce this. As I said in triage, we don't add error page loads to session history with SHIP. This was filed after bug 1674464 landed, but maybe Randell was running an older nightly? Or we somehow load about:restartrequired without marking it as an error page, but then we'd record that in session history without SHIP too.

Without steps to reproduce in a recent nightly we can't do much here.

Comment 6

[Peter Van der Beken [:peterv]]

Randell, did this happen for you recently?

Comment 7

[Neha Kochar [:neha]]

Randell said he hasn't experienced this again. No STR to follow-up here, pushing this out to M8 unless someone experiences this again and has better STR.

Comment 8

[Neha Kochar [:neha]]

Closing as no more reports of this. Please reopen if this happens again and provide more info for us to debug further.