1690186 - Proton Tab Styling Conflicts with Container Tabs Indicator

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[John]

Attachment: about:support

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Enabled Container Tabs through one of the many different addons.

Actual results:

The Proton Tab subtext has insufficient padding when the coloured container tabs indicator is enabled.

Expected results:

Sufficient padding be present between the media status subtext and the container tabs indicated

Comment 1

[John]

Please see the attached screenshot to see the issue.

Comment 2

[John]

Attachment: Container Tabs Spacing Issue.png

Comment 3

[John]

I don't want to spam this bug, but I just wanted to leave a quick note that this is still valid after the fixing of Bug 1688072, and Bug 1689852.

It is much improved, but a slight lack of padding at the bottom while media is playing still arguably looks a little unintentional, as can be seen in the newly attached screenshot.

Comment 4

[John]

Attachment: New Screenshot After Bug Fixes.png

Comment 5

[John]

Attachment: Screenshot - After Bug Fixes (gjpqy).png

Comment 6

[John]

The amount of impact obviously also seems to depend on the name of the page, particularly if the page title contains a g, j, p, q or y, per the last new screenshot.

Comment 7

[Romain Testard [:RT]]

Aaron, can you please help provide details here?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1690186 - Adjust the container tab styling to fit with the Proton theme.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62b9712b6c1e
Adjust the container tab styling to fit with the Proton theme. r=mconley

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/62b9712b6c1e

Comment 11

[katieC]

UX Update: Figma file updated with new visual spec for container visual treatment. Jaws has link and details.

Comment 12

[Negritas Sergiu, Desktop QA]

Hello I have managed to reproduce the issue with Fx 87.0a1 (2021-02-01) on Ubuntu 20, I can confirm that the issue is fixed with Fx 88.0a1(2021-03-16). I will update the flags accordingly.

Thank you!