1690217 - Add a test for the eyedropper with iframes

Status: RESOLVED FIXED

(DevTools :: Inspector, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Let's add a test to check that the eyedropper can pick colors from iframes (same-origin and remote)

The test will be tagged as fail-if on fission until Bug 1568831 is done.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1690217 - [devtools] Add test for eyedropper on page with iframes. r=ladybenko.

This adds a test that checks that the eyedropper displays the expected
colors when hovering iframes (same origin and remote).
Since we're going to do extra work from the client in Bug 1568831 to
actually get the screenshot, we can't simply use the regular inspector
test highlighter helper, as it spawns an eyedropper eyelighter on its
own, without calling the inspector client code.
And since we can't use the helper, we can't use the testActor method
that the other tests use, as we don't have an highlighter front for
the eyedropper.
We create new methods on the testActor which will retrieve the eyedropper
instance that is created by the inspector actor.
The new test expectedly fails on fission and is tagged as fail-if.
We take this as an opportunity to enhance the simple eyedropper test
so we actually uses the button in the ui instead of only manipulating it
through the test actor.

Depends on D103613

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission M7 (blocking Beta experiment).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00b7da171501
[devtools] Add test for eyedropper on page with iframes. r=ladybenko.

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/00b7da171501