1690225 - Remove focus-visible feature flag

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

We shipped this so we should do this now.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1690225 - Remove focus-visible feature flag. r=edgar

This shipped in 85, we can remove the feature flag now. Keep
:-moz-focusring as an alias to :focus-visible at parse time.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1690225 - Unify focus-visible rules in ua.css. r=edgar

We had different rules with the same declarations for all namespaces, so
simplify that setup by having a single rule.

Remove redundant | from selectors while at it (there's no default
namespace in ua.css, so there's no need to do that).

Depends on D103752

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cde1d10aae1c
Remove focus-visible feature flag. r=edgar
https://hg.mozilla.org/integration/autoland/rev/381ee01f5034
Unify focus-visible rules in ua.css. r=edgar

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1690225) for causing multiple bc failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c09ab610821bfadb714fcfd632968cd95ebeb22a

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=c09ab610821bfadb714fcfd632968cd95ebeb22a&fromchange=eda77cc87d49105b44830fb41dccec4738864003&searchStr=bc&selectedTaskRun=YiHJ1rn6Rb-Gax6cNQPKjQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=328640396&repo=autoland&lineNumber=2304

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3d49d6fe821
Remove focus-visible feature flag. r=edgar

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fe7fef2859b
Unify focus-visible rules in ua.css. r=edgar

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Thanks, quite an odd failure. But I forgot to deal with XUL so that should fix it.

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c3d49d6fe821
https://hg.mozilla.org/mozilla-central/rev/3fe7fef2859b