1690244 - Move WebRender initialization code out of renderer.rs

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Nicolas Silva [:nical]]

There's too much going on in renderer.rs, Setting up scene builder threads and the liks should not be part of it.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1690244 - Move WebRender initialization code out of renderer.rs. r=#gfx-reviewers

There is a lot going on in renderer.rs, the initialization code takes a non-negligible chunk of it and touches all aspects of WebRender including setting up all of the threads. This patch moves it into its own init module.
In addition, RendererOptions is renamed into WebRenderOptions to better reflect that it configures every aspect of the engine, and init::create_webrender_instance replaces Renderer::new.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nical, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Nicolas Silva [:nical]]

Will do eventually, no rush since it's a cleanup patch.

Comment 4

[Glenn Watson [:gw]]

We should probably just close this, since (I assume) there's no way to rebase this patch given how old it is?

Comment 5

[Nicolas Silva [:nical]]

I had forgotten about it. I ended up redoing it as it was a pretty mechanical change.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6237668e5fca
Move WebRender initialization code out of renderer.rs. r=kvark

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset 6237668e5fca (Bug 1690244) for causing webrender build bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=P2jGR1CbSYSiEK0slCRLZw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6237668e5fca50be5adbf0bd6e45168bcb5caabd

Log: https://treeherder.mozilla.org/logviewer?job_id=387036595&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/d7449f75f979874b467ad58d1a74338a2f27e8bd

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80344433c723
Move WebRender initialization code out of renderer.rs. r=kvark

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/80344433c723