1690335 - Print preview orientation flipped

Status: RESOLVED DUPLICATE of bug 1691286

(Core :: Print Preview, defect)

Description

[serpher]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.142 Safari/537.36

Steps to reproduce:

Print preview any kind of web page or PDF

Actual results:

Orientation of the document is flipped even though buttons say otherwise.
Screenshots:
https://imgur.com/a/3UVFdwn

Expected results:

Default orientation should be portrait.

Comment 1

[Daniel Holbert [:dholbert]]

Thank you. I can't reproduce this locally, and our QA folks didn't run across this issue, so I suspect there's something special about your setup that would be important to identify so we can figure out what's going on.

Could you let us know:

1. what paper size you are printing to (I'm guessing A4?)
2. what happens when you proceed to actually print? (Does Firefox e.g. say "portrait", and preview shows landscape, and we print in landscape mode? or do we print in portrait mode? or do we print portrait-cropped-to-landscape, or something terrible like that?
3. if you enable our new unified print/print-preview dialog, does this still happen? (You can opt in to the new print dialog by visiting about:config, type "print.tab_modal.enabled" into the search box, and click the button at the right end of the line that comes up to set the preference to true. After you've done that, your next print operation should use the new dialog.)
4. If you create a new Firefox profile, is that one affected too? (To test that, you would use the "Create a new profile" button at the special Firefox page about:profiles, and then click "Launch profile in new browser" for that newly-created profile -- see https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles for more.)

Thank you for the report and for your help tracking this down.

[Tracking Requested - why for this release]: Looks like a fairly serious print-configuration regression in Firefox 85.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: reporter's screenshot #1 (the selected orientation-button translates to "Horizontal", but we're showing a portrait-mode page)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: reporter's screenshot #2 (the selected orientation-button translates to "Vertical", but we're showing a landscape-mode page)

Comment 4

[Daniel Holbert [:dholbert]]

(Ticking "needinfo" to be sure you see comment 1.)

Comment 5

[Peter Magyari (Desktop QA)]

Unfortunately I wasn't able to reproduce this on my end on either Firefox 85 or Firefox Nightly 87.0a1.

I've tried both with the unified print modal On and Off on two separate PCs and also tried several page settings but to no avail.

Comment 6

[serpher]

(In reply to Daniel Holbert [:dholbert] from comment #1)

Thank you. I can't reproduce this locally, and our QA folks didn't run across this issue, so I suspect there's something special about your setup that would be important to identify so we can figure out what's going on.

Could you let us know:

1. what paper size you are printing to (I'm guessing A4?)
2. what happens when you proceed to actually print? (Does Firefox e.g. say "portrait", and preview shows landscape, and we print in landscape mode? or do we print in portrait mode? or do we print portrait-cropped-to-landscape, or something terrible like that?
3. if you enable our new unified print/print-preview dialog, does this still happen? (You can opt in to the new print dialog by visiting about:config, type "print.tab_modal.enabled" into the search box, and click the button at the right end of the line that comes up to set the preference to true. After you've done that, your next print operation should use the new dialog.)
4. If you create a new Firefox profile, is that one affected too? (To test that, you would use the "Create a new profile" button at the special Firefox page about:profiles, and then click "Launch profile in new browser" for that newly-created profile -- see https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles for more.)

Thank you for the report and for your help tracking this down.

[Tracking Requested - why for this release]: Looks like a fairly serious print-configuration regression in Firefox 85.

I made new profile but it didn't make a difference. New modal print preview shows orientation correctly but the old preview window doesn't
I'm on 86b6.

Comment 7

[Daniel Holbert [:dholbert]]

So it sounds like Firefox 86 (beta) is the only version where you've been able to reproduce this problem -- is that correct?

(I had initially assumed that you were hitting this in Firefox release 85, but it sounds like I was wrong about that.)

Comment 8

[Pascal Chevrel:pascalc]

There is a mention about something similar reported today to the FirefoxBeta account: https://twitter.com/dread_arisawa/status/1358812004132167680
There is a similar report on Element today which mentions that the bug affects 86 beta 7.

CCing our QA on this to help find a regression range.

Comment 9

[Emil Ghitta, QA [:emilghitta]]

Attachment: preview.gif

I have managed to reproduce this behavior by:

1. Enabling the print.tab_modal.enabled pref.
2. Switching the orientation to landscape and initiating a print job to my physical printer.
3. Disabling the print.tab_modal.enabled pref.
4. Accessing a random page and opening the old print preview.

My guess is that the reporter may have encountered this issue by initially using the new modernized print preview, printed with a specific landscape option and updated Firefox beta to the latest version (which has the print.tab_modal.enabled disabled by default)

Looking for the regression range.

Comment 10

[Emil Ghitta, QA [:emilghitta]]

Regression range for the steps in comment 9:

6:21.82 INFO: Last good revision: dd7dd05a7b9d36602cd8b80c145584b11f375afa
6:21.82 INFO: First bad revision: 00d01574ddeffbd6fea7076f9dbf672e1dfd7c80
6:21.82 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dd7dd05a7b9d36602cd8b80c145584b11f375afa&tochange=00d01574ddeffbd6fea7076f9dbf672e1dfd7c80

Possible regressor: Bug 1669905

This issue may have been fixed by the patch from Bug 1691286 ( I am unable to reproduce this issue with the latest nightly build).

Reporter, can you please try and verify if this issue is still reproducible on your side while using the latest Firefox nightly build ?(https://www.mozilla.org/en-US/firefox/channel/desktop/)

Comment 11

[Daniel Holbert [:dholbert]]

Thanks! I have a high degree of confidence that this is the same underlying issue as bug 1691286, given:

• Emil's observations (on regression range & unreproducibility-in-today's nightly)
• the reporter's mention of 86 beta (comment 6), which is consistent with the expected regression range
• the nature of the bug/patch in bug 1691286 (which had landscape/portrait flipped in the code in one spot)

Hence, I'm marking as a duplicate -- serpher, please reopen if you happen to still be able to reproduce in Firefox Nightly from today or newer (with the print.tab_modal.enabled pref turned off); or in the next beta update, Firefox 86b8.