1690362 - In the last row I can't join the selected cells

Status: ASSIGNED

(SeaMonkey :: Composer, defect)

Description

[ricsi.pap]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.6

Steps to reproduce:

I tried the join the selected cells.
I appointed the selected cells -> Right Click -> Join selected cells

Actual results:

Nothing.

Expected results:

The cells should have merged.

Comment 1

[Nuno Silva [:njsg]]

Bug 962557 has an image with an example of how to reproduce this; merging without selecting first ("Join with Cell to the Right") still works in the last row, as that goes through different code in JoinTableCells.

Comment 2

[Nuno Silva [:njsg]]

Attachment: WIP-1690362-allow-null.patch

draft/WIP/test patch that makes GetCellDataAt() succeed even if there is no such cell (something worth testing, as this was what happened in 2.16)

Comment 3

[Ian Neal]

Comment on attachment 9335140 [details] [diff] [review]
WIP-1690362-allow-null.patch

It's better now, but it doesn't delete the cell, so ends up creating an extra column with that cell in the bottom row.

Original HTML:
<table width="100%" cellspacing="2" cellpadding="2" border="1">
<tbody>
<tr>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
</tr>
<tr>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
</tr>
<tr>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
</tr>
</tbody>
</table>

After merge:
<table width="100%" cellspacing="2" cellpadding="2" border="1">
<tbody>
<tr>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
</tr>
<tr>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
<td valign="top"><br>
</td>
</tr>
<tr>
<td valign="top"><br>
</td>
<td rowspan="1" colspan="2" valign="top"><br>
</td>
<td valign="top"><br>
</td>
</tr>
</tbody>
</table>

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9335140 [details] [diff] [review]
WIP-1690362-allow-null.patch

Backed out from 2.53. prerelease for now.