Closed
Bug 1690391
Opened 4 years ago
Closed 4 years ago
Fix fluent error: "[fluent][resolver] errors in en-US/do-import-multiple: Resolver error: Unknown variable: $key" when importing public key.
Categories
(MailNews Core :: Security: OpenPGP, task)
MailNews Core
Security: OpenPGP
Tracking
(thunderbird_esr78 wontfix, thunderbird86 wontfix)
RESOLVED
FIXED
87 Branch
People
(Reporter: lasana, Assigned: lasana)
Details
Attachments
(1 file)
|
2.23 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
This is a minor discrepancy. The data-l10n-id assigned to the #importLabel expects a variable $key to be passed. It's dynamically updated after the fact to show correctly.
|
Assignee | |
Comment 1•4 years ago
|
||
Removed the l10n id from markup and have the translation happen once instead.
Attachment #9200762 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9200762 [details] [diff] [review]
bug1690391.patch
Review of attachment 9200762 [details] [diff] [review]:
-----------------------------------------------------------------
The alternative would be to put `data-l10n-args='{"key": 0}'` into the markup.
Attachment #9200762 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•4 years ago
|
Status: NEW → ASSIGNED
status-thunderbird86:
--- → wontfix
status-thunderbird_esr78:
--- → wontfix
Target Milestone: --- → 87 Branch
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/679316f93fd4
Fix fluent warning about missing $key variable when importing public keys. r=mkmelin
You need to log in
before you can comment on or make changes to this bug.
Description
•