1690406 - Update AVIF telemetry probes

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P1)

Description

[Jon Bauman [:jbauman:]]

There are currently two issues with the AVIF telemetry probes added in bug 1670827:

1. The !aIsMetadataDecode condition for recording the return value of dav1d_get_picture is backward. It should be aIsMetadataDecode, since nsAVIFDecoder::DoDecode won't be called a second time if there is a decoding error, so no telemetry for errors returned from dav1d_get_picture would ever be recorded. The condition for the aom_codec_decode case is correct.
2. The ScalarSet telemetry function isn't appropriate for recording this data, since multiple calls within the same session will overwrite each other. The goal here is to record all the different error values we see from the decoder libraries in order to investigate the cause. We believe errors in decoding should be rare.

Comment 1

[Jon Bauman [:jbauman:]]

Attachment: Bug 1690406 - Update AVIF telemetry probes. r=chutten

Comment 2

[Jon Bauman [:jbauman:]]

Attachment: data-review-bug-1690406.md

Comment 3

[Chris H-C :chutten]

Comment on attachment 9201893 [details]
data-review-bug-1690406.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Chun-Min Chang and Jon Bauman are responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93f1b2668314
Update AVIF telemetry probes. r=chutten

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/93f1b2668314