1690417 - Tooltip appears under Reader mode menu

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P5)

Description

[Mathew Hodson]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

1. Go to https://getpocket.com/explore/item/the-science-of-good-chocolate
2. Click the Type controls button to open the menu
3. Hover over the Pocket button

Actual results:

The tooltip for the Pocket button is under the menu.

Expected results:

Tooltips should have a consistent appearance.

Comment 1

[Mathew Hodson]

Attachment: Screebshot showing tooltip behind menu.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Mathew Hodson]

Attachment: Screenshot showing tooltip over main Firefox menu.

The tooltips for the other buttons were hidden in bug 1655402, but I think it would be more consistent if the tooltips were just on top of the menu. That's how it works for other menus like the main Firefox menu.

Comment 4

[:Gijs (he/him)]

I'd take a patch for this. Mathew, don't suppose you have an interest in providing one? :-)

Comment 5

[Mathew Hodson]

(In reply to :Gijs (he/him) from comment #4)

I'd take a patch for this. Mathew, don't suppose you have an interest in providing one? :-)

Which approach? To just hide the tooltip for the Pocket button or make all of them visible on top of the menu?

Comment 6

[:Gijs (he/him)]

(In reply to Mathew Hodson from comment #5)

(In reply to :Gijs (he/him) from comment #4)

I'd take a patch for this. Mathew, don't suppose you have an interest in providing one? :-)

Which approach? To just hide the tooltip for the Pocket button or make all of them visible on top of the menu?

I think hiding only the tooltip of the currently open menu (because showing that one makes no real sense and will likely make the initial opening of the menu look odd) and adding a shadow around the others and showing them on top of the menu would make sense. Does that sound right?

Comment 7

[Mathew Hodson]

(In reply to :Gijs (he/him) from comment #6)

I think hiding only the tooltip of the currently open menu (because showing that one makes no real sense and will likely make the initial opening of the menu look odd) and adding a shadow around the others and showing them on top of the menu would make sense. Does that sound right?

That sounds good to me. I can try to write a patch, but it might be awhile since I don't have space for the repo right now.

Comment 8

[Mathew Hodson]

Attachment: Bug 1690417 - Show tooltips when a reader mode dropdown is open. r=jaws

Don't show the tooltip of the currently open dropdown button
so that the opening of the dropdown popup doesn't look odd.

Comment 9

[Mathew Hodson]

Can you help me land this patch?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d806baa4c336
Show tooltips when a reader mode dropdown is open. r=desktop-theme-reviewers,harry

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d806baa4c336

Comment 12

[:Gijs (he/him)]

(Sorry, it appears that the patch here being created happened to coincide with me being on PTO, which I imagine didn't make things easier. But I'm glad this landed - thank you!)