1690421 - Libabigail update breaks image build in CI

Status: RESOLVED FIXED

(NSS :: Test, enhancement)

Description

[Kevin Jacobs [:kjacobs]]

Libabigail recently released libabigail-1.8.1 (main is now 2.0). These versions depend on libdw for the definition of DW_FORM_line_strp. Ubuntu 18.04 (which is used by the docker image) uses an older version that doesn't have this define, leading to a build failure.

  CXX      abg-dwarf-reader.lo
In file included from /libabigail/include/abg-ir.h:24,
                 from abg-ir-priv.h:18,
                 from abg-dwarf-reader.cc:36:
abg-dwarf-reader.cc: In function 'bool abigail::dwarf_reader::compare_dies_string_attribute_value(const Dwarf_Die*, const Dwarf_Die*, unsigned int, bool&)':
abg-dwarf-reader.cc:9418:25: error: 'DW_FORM_line_strp' was not declared in this scope; did you mean 'DW_FORM_strp'?
 9418 |       || l_attr.form == DW_FORM_line_strp);
      |                         ^~~~~~~~~~~~~~~~~
/libabigail/include/abg-fwd.h:1421:57: note: in definition of macro 'ABG_ASSERT'
 1421 | #define ABG_ASSERT(cond) do {({bool __abg_cond__ = bool(cond); assert(__abg_cond__); !!__abg_cond__;});} while (false)
      |                                                         ^~~~
abg-dwarf-reader.cc:9424:25: error: 'DW_FORM_line_strp' was not declared in this scope; did you mean 'DW_FORM_strp'?
 9424 |       || l_attr.form == DW_FORM_line_strp);
      |                         ^~~~~~~~~~~~~~~~~
/libabigail/include/abg-fwd.h:1421:57: note: in definition of macro 'ABG_ASSERT'
 1421 | #define ABG_ASSERT(cond) do {({bool __abg_cond__ = bool(cond); assert(__abg_cond__); !!__abg_cond__;});} while (false)
      |                                                         ^~~~
abg-dwarf-reader.cc:9432:26: error: 'DW_FORM_line_strp' was not declared in this scope; did you mean 'DW_FORM_strp'?
 9432 |       || (l_attr.form == DW_FORM_line_strp
      |                          ^~~~~~~~~~~~~~~~~
      |                          DW_FORM_strp
Makefile:568: recipe for target 'abg-dwarf-reader.lo' failed
make[2]: *** [abg-dwarf-reader.lo] Error 1

We should update the docker image or checkout libabigail-1.8 before building.

Comment 1

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1690421 - Install packaged libabigail in docker-builds image

Comment 2

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1690421 - Adjust 3.62 ABI report formatting for new libabigail.

Comment 3

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/rev/3c719b62013685a7a91e0e4876242fcd997e5a38
https://hg.mozilla.org/projects/nss/rev/a1ed44dba32ef8e82cc343d2de26bac20e32d0bc